Xen devel - Aug 2011 - [PATCH] tone down the WARN_ON about unexpected APIC writes

These occurrences are largely benign these days and tainting the kernel
for them is a bit aggressive. Mostly they relate to failing to setup
perf which I think we are all aware is something which needs attention
on the Xen/pvops side.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 974a528..55e3cc7 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -724,8 +724,9 @@ static u32 xen_apic_read(u32 reg)
 
 static void xen_apic_write(u32 reg, u32 val)
 {
-	/* Warn to see if there''s any stray references */
-	WARN_ON(1);
+	printk(KERN_WARNING "xen: unexpected APIC write %#x to reg %#x\n",
+	       val, reg);
+	dump_stack();
 }
 
 static u64 xen_apic_icr_read(void)
@@ -735,8 +736,9 @@ static u64 xen_apic_icr_read(void)
 
 static void xen_apic_icr_write(u32 low, u32 id)
 {
-	/* Warn to see if there''s any stray references */
-	WARN_ON(1);
+	printk(KERN_WARNING "xen: unexpected APIC ICR write %#x %#x\n",
+	       id, low);
+	dump_stack();
 }
 
 static void xen_apic_wait_icr_idle(void)



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel