Hi! Attached patch fixes linking error when creating the xl binary. The xl binary compiles in xl_cmdimpl.c which calls code from libxl_paths.c and libxl_bootloader.c. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking
error"):> Attached patch fixes linking error when creating the xl binary.
> The xl binary compiles in xl_cmdimpl.c which calls code from
> libxl_paths.c and libxl_bootloader.c.
...> -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so
> +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o
libxl_bootloader.o libxlutil.so libxenlight.so
This can''t possibly be right. Files called "libxl_*.o" are
parts of
libxl and should be in libxenlight.so.
I see, however, that Stefano has already applied it.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Wed, 21 Jul 2010, Ian Jackson wrote:> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"): > > Attached patch fixes linking error when creating the xl binary. > > The xl binary compiles in xl_cmdimpl.c which calls code from > > libxl_paths.c and libxl_bootloader.c. > ... > > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so > > +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so > > This can''t possibly be right. Files called "libxl_*.o" are parts of > libxl and should be in libxenlight.so. > > I see, however, that Stefano has already applied it. >Yes, sorry I missed it. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wednesday 21 July 2010 18:14:14 Stefano Stabellini wrote:> On Wed, 21 Jul 2010, Ian Jackson wrote: > > Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"): > > > Attached patch fixes linking error when creating the xl binary. > > > The xl binary compiles in xl_cmdimpl.c which calls code from > > > libxl_paths.c and libxl_bootloader.c. > > > > ... > > > > > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so > > > libxenlight.so +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o > > > libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so > > > > This can''t possibly be right. Files called "libxl_*.o" are parts of > > libxl and should be in libxenlight.so. > > > > I see, however, that Stefano has already applied it. > > Yes, sorry I missed it.I realized this patch is wrong. Please apply the patch to correct this: http://lists.xensource.com/archives/html/xen-devel/2010-07/msg01068.html Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel