Hi Ian,
I hit an error when compiling latest xen-unstable + qemu-xen-unstable:
$ DESTDIR=/share/tmp/pkg/xen-unstable/dist/install make install-tools
...
qemu successfuly configured for Xen qemu-dm build
make -C ioemu-dir install
=== PCI passthrough capability has been enabled ==make[3]: Entering directory
`/share/tmp/pkg/qemu-xen-unstable''
CC qemu-nbd.o
In file included from ./config-host.h:20,
from ./qemu-common.h:33,
from qemu-nbd.c:20:
./xen-config-host.h:31: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’
before ‘*’ token
make[3]: *** [qemu-nbd.o] Error 1
make[3]: Leaving directory `/share/tmp/pkg/qemu-xen-unstable''
make[2]: *** [subdir-install-ioemu-dir] Error 2
make[2]: Leaving directory `/share/tmp/pkg/xen-unstable/tools''
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/share/tmp/pkg/xen-unstable/tools''
make: *** [install-tools] Error 2
Seems this commit is incomplete:
commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Thu Apr 15 17:01:15 2010 +0100
Change callers of libxc to use new libxc API.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
I cannot find the definition of xc_interface.
Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish the
build.
Thanks,
Zhigang
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 28/05/2010 08:23, "Zhigang Wang" <zhigang.x.wang@oracle.com> wrote:> Seems this commit is incomplete: > > commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30 > Author: Ian Jackson <ian.jackson@eu.citrix.com> > Date: Thu Apr 15 17:01:15 2010 +0100 > > Change callers of libxc to use new libxc API. > > Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> > > I cannot find the definition of xc_interface. > > Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish the > build.Perhaps your build is not respecting the QEMU_TAG in Config.mk, for some reason? There are (humungous) patches pending on xen-unstable.hg which will introduce xc_interface. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 05/28/2010 04:14 PM, Keir Fraser wrote:> On 28/05/2010 08:23, "Zhigang Wang" <zhigang.x.wang@oracle.com> wrote: > >> Seems this commit is incomplete: >> >> commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30 >> Author: Ian Jackson <ian.jackson@eu.citrix.com> >> Date: Thu Apr 15 17:01:15 2010 +0100 >> >> Change callers of libxc to use new libxc API. >> >> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> >> >> I cannot find the definition of xc_interface. >> >> Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish the >> build. > > Perhaps your build is not respecting the QEMU_TAG in Config.mk, for some > reason? There are (humungous) patches pending on xen-unstable.hg which will > introduce xc_interface. > > -- KeirI created soft links to the qemu-xen-unstable tree: rwxrwxrwx 1 zhigang zhigang 12 2010-05-28 15:19 ioemu-dir -> ioemu-remote lrwxrwxrwx 1 zhigang zhigang 23 2010-05-11 08:23 ioemu-remote -> ../../qemu-xen-unstable So it will not checkout the tag. Seems the QEMU_TAG hack is not a good enough. I''m wondering whether can we make master always be compiled and rename QEMU_TAG to QEMU_BRANCH? All experimental patches go to another branch and users set the QEMU_BRANCH for testing. Thanks, Zhigang _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I meet the issue just now. In the end I enter the ioemu-remote and do the
branch/checkout manually.
When will the ioemu_remote be updated? Seems it will only be updated if this
directory does not exist?
if [ ! -d ioemu-remote ]; then \
rm -rf ioemu-remote ioemu-remote.tmp; \
mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \
$(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
if [ "$(QEMU_TAG)" ]; then
\
cd ioemu-remote.tmp; \
$(GIT) branch -D dummy >/dev/null 2>&1
||:; \
$(GIT) checkout -b dummy $(QEMU_TAG); \
cd ..; \
fi; \
mv ioemu-remote.tmp ioemu-remote; \
Thanks
--jyh
>-----Original Message-----
>From: xen-devel-bounces@lists.xensource.com
>[mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Keir Fraser
>Sent: Friday, May 28, 2010 4:15 PM
>To: Zhigang Wang; Ian Jackson
>Cc: xen-devel
>Subject: Re: [Xen-devel] qemu-xen-unstable build error
>
>On 28/05/2010 08:23, "Zhigang Wang"
<zhigang.x.wang@oracle.com> wrote:
>
>> Seems this commit is incomplete:
>>
>> commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30
>> Author: Ian Jackson <ian.jackson@eu.citrix.com>
>> Date: Thu Apr 15 17:01:15 2010 +0100
>>
>> Change callers of libxc to use new libxc API.
>>
>> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
>>
>> I cannot find the definition of xc_interface.
>>
>> Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish
the
>> build.
>
>Perhaps your build is not respecting the QEMU_TAG in Config.mk, for some
>reason? There are (humungous) patches pending on xen-unstable.hg which will
>introduce xc_interface.
>
> -- Keir
>
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 28/05/2010 09:50, "Zhigang Wang" <zhigang.x.wang@oracle.com> wrote:> I created soft links to the qemu-xen-unstable tree: > > rwxrwxrwx 1 zhigang zhigang 12 2010-05-28 15:19 ioemu-dir -> > ioemu-remote > lrwxrwxrwx 1 zhigang zhigang 23 2010-05-11 08:23 ioemu-remote -> > ../../qemu-xen-unstable > > So it will not checkout the tag.Yes, I do similar (well, I specify CONFIG_QEMU) and so QEMU_TAG does nothing much for me also. Generally I find the build breaks rarely enough that I''ve never bothered to change things.> Seems the QEMU_TAG hack is not a good enough. I''m wondering whether can we > make > master always be compiled and rename QEMU_TAG to QEMU_BRANCH? All experimental > patches go to another branch and users set the QEMU_BRANCH for testing.Perhaps if CONFIG_QEMU is specified then the build system should clone from the local repository, or copy it (which is presumably fast) and then do a private checkout in that clone/copy, so that QEMU_TAG is always respected. Getting the right qemu version is a bit of a crapshoot right now. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Perhaps it should also check against QEMU_TAG if defined, even if the directory exists, and pull/checkout if necessary. K. On 28/05/2010 09:53, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:> I meet the issue just now. In the end I enter the ioemu-remote and do the > branch/checkout manually. > > When will the ioemu_remote be updated? Seems it will only be updated if this > directory does not exist? > > if [ ! -d ioemu-remote ]; then \ > rm -rf ioemu-remote ioemu-remote.tmp; \ > mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \ > $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \ > if [ "$(QEMU_TAG)" ]; then \ > cd ioemu-remote.tmp; \ > $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \ > $(GIT) checkout -b dummy $(QEMU_TAG); \ > cd ..; \ > fi; \ > mv ioemu-remote.tmp ioemu-remote; \ > > Thanks > --jyh > >> -----Original Message----- >> From: xen-devel-bounces@lists.xensource.com >> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Keir Fraser >> Sent: Friday, May 28, 2010 4:15 PM >> To: Zhigang Wang; Ian Jackson >> Cc: xen-devel >> Subject: Re: [Xen-devel] qemu-xen-unstable build error >> >> On 28/05/2010 08:23, "Zhigang Wang" <zhigang.x.wang@oracle.com> wrote: >> >>> Seems this commit is incomplete: >>> >>> commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30 >>> Author: Ian Jackson <ian.jackson@eu.citrix.com> >>> Date: Thu Apr 15 17:01:15 2010 +0100 >>> >>> Change callers of libxc to use new libxc API. >>> >>> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> >>> >>> I cannot find the definition of xc_interface. >>> >>> Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish the >>> build. >> >> Perhaps your build is not respecting the QEMU_TAG in Config.mk, for some >> reason? There are (humungous) patches pending on xen-unstable.hg which will >> introduce xc_interface. >> >> -- Keir >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yes, that may make life easier. --jyh>-----Original Message----- >From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] >Sent: Friday, May 28, 2010 4:58 PM >To: Jiang, Yunhong; Zhigang Wang; Ian Jackson >Cc: xen-devel >Subject: Re: [Xen-devel] qemu-xen-unstable build error > >Perhaps it should also check against QEMU_TAG if defined, even if the >directory exists, and pull/checkout if necessary. > > K. > >On 28/05/2010 09:53, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote: > >> I meet the issue just now. In the end I enter the ioemu-remote and do the >> branch/checkout manually. >> >> When will the ioemu_remote be updated? Seems it will only be updated if this >> directory does not exist? >> >> if [ ! -d ioemu-remote ]; then \ >> rm -rf ioemu-remote ioemu-remote.tmp; \ >> mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; >\ >> $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; >\ >> if [ "$(QEMU_TAG)" ]; then >\ >> cd ioemu-remote.tmp; >\ >> $(GIT) branch -D dummy >/dev/null 2>&1 >||:; \ >> $(GIT) checkout -b dummy $(QEMU_TAG); >\ >> cd ..; >\ >> fi; >\ >> mv ioemu-remote.tmp ioemu-remote; \ >> >> Thanks >> --jyh >> >>> -----Original Message----- >>> From: xen-devel-bounces@lists.xensource.com >>> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Keir Fraser >>> Sent: Friday, May 28, 2010 4:15 PM >>> To: Zhigang Wang; Ian Jackson >>> Cc: xen-devel >>> Subject: Re: [Xen-devel] qemu-xen-unstable build error >>> >>> On 28/05/2010 08:23, "Zhigang Wang" <zhigang.x.wang@oracle.com> wrote: >>> >>>> Seems this commit is incomplete: >>>> >>>> commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30 >>>> Author: Ian Jackson <ian.jackson@eu.citrix.com> >>>> Date: Thu Apr 15 17:01:15 2010 +0100 >>>> >>>> Change callers of libxc to use new libxc API. >>>> >>>> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> >>>> >>>> I cannot find the definition of xc_interface. >>>> >>>> Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish >the >>>> build. >>> >>> Perhaps your build is not respecting the QEMU_TAG in Config.mk, for some >>> reason? There are (humungous) patches pending on xen-unstable.hg which will >>> introduce xc_interface. >>> >>> -- Keir >>> >>> >>> >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel