Wei Wang2
2010-Dec-03 16:03 UTC
[Xen-devel] [PATCH 2/4] amd iommu: Large io page support - parameter
Add a xen parameter (iommu=superpage) to enable iommu super page. Thanks, We Signed-off-by: Wei Wang <wei.wang2@amd.com> -- Legal Information: Advanced Micro Devices GmbH Sitz: Dornach, Gemeinde Aschheim, Landkreis München Registergericht München, HRB Nr. 43632 Geschäftsführer: Alberto Bozzo, Andrew Bowd _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Dec-03 16:14 UTC
Re: [Xen-devel] [PATCH 2/4] amd iommu: Large io page support - parameter
Why? If the system supports superpages, use them. Simple. -- Keir On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@amd.com> wrote:> Add a xen parameter (iommu=superpage) to enable iommu super page. > Thanks, > We > Signed-off-by: Wei Wang <wei.wang2@amd.com> > -- > Legal Information: > Advanced Micro Devices GmbH > Sitz: Dornach, Gemeinde Aschheim, > Landkreis München Registergericht München, > HRB Nr. 43632 > Geschäftsführer: > Alberto Bozzo, Andrew Bowd > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Wei Wang2
2010-Dec-03 16:19 UTC
Re: [Xen-devel] [PATCH 2/4] amd iommu: Large io page support - parameter
Keir, It could be used to disable super iommu page if the new codes have some issues. But I am OK with removing it if you think this parameter is unnecessary. Thanks, Wei On Friday 03 December 2010 17:14:12 Keir Fraser wrote:> Why? If the system supports superpages, use them. Simple. > > -- Keir > > On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@amd.com> wrote: > > Add a xen parameter (iommu=superpage) to enable iommu super page. > > Thanks, > > We > > Signed-off-by: Wei Wang <wei.wang2@amd.com> > > -- > > Legal Information: > > Advanced Micro Devices GmbH > > Sitz: Dornach, Gemeinde Aschheim, > > Landkreis München Registergericht München, > > HRB Nr. 43632 > > Geschäftsführer: > > Alberto Bozzo, Andrew Bowd > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Dec-03 16:29 UTC
Re: [Xen-devel] [PATCH 2/4] amd iommu: Large io page support - parameter
On 03/12/2010 08:19, "Wei Wang2" <wei.wang2@amd.com> wrote:> Keir, > It could be used to disable super iommu page if the new codes have some > issues. But I am OK with removing it if you think this parameter is > unnecessary.Yeah there''s a judgement call there. But we don''t add command-line flags for every new feature we implement, and in this case I don''t think it''s worthwhile. The iommu= set of parameters is hairy enough as it is. We can always add the parameter *if* it proves to be worthwhile. -- Keir> Thanks, > Wei > > On Friday 03 December 2010 17:14:12 Keir Fraser wrote: >> Why? If the system supports superpages, use them. Simple. >> >> -- Keir >> >> On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@amd.com> wrote: >>> Add a xen parameter (iommu=superpage) to enable iommu super page. >>> Thanks, >>> We >>> Signed-off-by: Wei Wang <wei.wang2@amd.com> >>> -- >>> Legal Information: >>> Advanced Micro Devices GmbH >>> Sitz: Dornach, Gemeinde Aschheim, >>> Landkreis München Registergericht München, >>> HRB Nr. 43632 >>> Geschäftsführer: >>> Alberto Bozzo, Andrew Bowd >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel