Wei Wang2
2010-Dec-03 16:03 UTC
[Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
This patch extends generic iommu interfaces to support different page size. Thanks, Wei Signed-off-by: Wei Wang <wei.wang2@amd.com> -- Legal Information: Advanced Micro Devices GmbH Sitz: Dornach, Gemeinde Aschheim, Landkreis München Registergericht München, HRB Nr. 43632 Geschäftsführer: Alberto Bozzo, Andrew Bowd _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Dec-03 16:17 UTC
Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
Why add new map/unmap calls. Better just to extend the existing calls to be able to act on a range, eh? That way you won''t end up stubbing out and breaking Intel support in patch 3, either... -- Keir On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@amd.com> wrote:> This patch extends generic iommu interfaces to support different page size. > > Thanks, > Wei > Signed-off-by: Wei Wang <wei.wang2@amd.com> > -- > Legal Information: > Advanced Micro Devices GmbH > Sitz: Dornach, Gemeinde Aschheim, > Landkreis München Registergericht München, > HRB Nr. 43632 > Geschäftsführer: > Alberto Bozzo, Andrew Bowd > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Dec-03 16:21 UTC
Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
Also the patch uses but does not define amd_iommu_map_pages(). Looks like you took one big patch and arbitrarily cut it up into a patch series. That is pointless if the series does not step-wise build and work. -- Keir On 03/12/2010 08:17, "Keir Fraser" <keir@xen.org> wrote:> Why add new map/unmap calls. Better just to extend the existing calls to be > able to act on a range, eh? That way you won''t end up stubbing out and > breaking Intel support in patch 3, either... > > -- Keir > > On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@amd.com> wrote: > >> This patch extends generic iommu interfaces to support different page size. >> >> Thanks, >> Wei >> Signed-off-by: Wei Wang <wei.wang2@amd.com> >> -- >> Legal Information: >> Advanced Micro Devices GmbH >> Sitz: Dornach, Gemeinde Aschheim, >> Landkreis München Registergericht München, >> HRB Nr. 43632 >> Geschäftsführer: >> Alberto Bozzo, Andrew Bowd >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Wei Wang2
2010-Dec-03 16:24 UTC
Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
Thanks, I will fix that. Wei On Friday 03 December 2010 17:21:03 Keir Fraser wrote:> Also the patch uses but does not define amd_iommu_map_pages(). Looks like > you took one big patch and arbitrarily cut it up into a patch series. That > is pointless if the series does not step-wise build and work. > > -- Keir > > On 03/12/2010 08:17, "Keir Fraser" <keir@xen.org> wrote: > > Why add new map/unmap calls. Better just to extend the existing calls to > > be able to act on a range, eh? That way you won''t end up stubbing out and > > breaking Intel support in patch 3, either... > > > > -- Keir > > > > On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@amd.com> wrote: > >> This patch extends generic iommu interfaces to support different page > >> size. > >> > >> Thanks, > >> Wei > >> Signed-off-by: Wei Wang <wei.wang2@amd.com> > >> -- > >> Legal Information: > >> Advanced Micro Devices GmbH > >> Sitz: Dornach, Gemeinde Aschheim, > >> Landkreis München Registergericht München, > >> HRB Nr. 43632 > >> Geschäftsführer: > >> Alberto Bozzo, Andrew Bowd > >> _______________________________________________ > >> Xen-devel mailing list > >> Xen-devel@lists.xensource.com > >> http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel