Xen devel - Sep 2010 - [PATCH] xl: do not return to caller from monitoring daemon

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1283529150 -3600
# Node ID be28cc7f45bbe2a592b2405e3130c8e537859ba8
# Parent  f2c0e187de98560ed6c7104cf6b2d4f9291b4704
xl: do not return to caller from monitoring daemon

The parent process will have returned to the caller and done whatever
is necessary. The daemon should not return otherwise it will repeat
this work. In the case of the migration receiver this causes it to try
and take part in the migration protocol long after the sender+parent
process have completed it, leading to confusing error messages
(although strangely not much actual damange).

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r f2c0e187de98 -r be28cc7f45bb tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Fri Sep 03 15:56:11 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Fri Sep 03 16:52:30 2010 +0100
@@ -1635,6 +1635,12 @@ out:
 
     free(config_data);
 
+    /*
+     * If we have daemonized then do not return to the caller -- this
+     * has already happened in the parent.
+     */
+    if ( !need_daemon )
+        exit(ret);
     return ret;
 }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ian Campbell writes ("[Xen-devel] [PATCH] xl: do not return to caller from
monitoring daemon"):
> xl: do not return to caller from monitoring daemon
> 
> The parent process will have returned to the caller and done whatever
> is necessary. The daemon should not return otherwise it will repeat
> this work. In the case of the migration receiver this causes it to try
> and take part in the migration protocol long after the sender+parent
> process have completed it, leading to confusing error messages
> (although strangely not much actual damange).
How exciting.

Unfortunately your patch doesn''t apply any more because of
fde833c66948.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel