Hi, latest xen-unstable doesn''t build on my machine: gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xen-hptool.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Werror -I ../../tools/python/xen/lowlevel/xc -I ../../tools/libxc -I ../../tools/include -c -o xen-hptool.o xen-hptool.c xen-hptool.c: In function ‘suspend_guest’: xen-hptool.c:136: error: too few arguments to function ‘xc_suspend_evtchn_release’ xen-hptool.c: In function ‘hp_mem_offline_func’: xen-hptool.c:231: error: too few arguments to function ‘xc_suspend_evtchn_release’ make[3]: *** [xen-hptool.o] Error 1 make[3]: Leaving directory `/root/xen-unstable.hg/tools/misc'' Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I thing Yang''s patch is still not applied. And the build error is my
mistake.. I missed the xen-hptool.c file
changeset 21259:f7605c6c9548 changes the global suspend event channel lock
file
to a per-domain lock file, but do not update xc_suspend_evtchn_release()
call in
misc/hp-tool.c. So I got a build error when building tools. The patch fix
this.
Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
diff -r efa1b905d893 tools/misc/xen-hptool.c
--- a/tools/misc/xen-hptool.c Tue May 04 13:59:55 2010 +0100
+++ b/tools/misc/xen-hptool.c Wed May 05 19:56:51 2010 +0800
@@ -133,7 +133,7 @@
failed:
if (suspend_evtchn != -1)
- xc_suspend_evtchn_release(xce, suspend_evtchn);
+ xc_suspend_evtchn_release(xce, domid, suspend_evtchn);
return -1;
}
@@ -228,7 +228,7 @@
mfn, domid);
}
xc_domain_resume(xc_fd, domid, 1);
- xc_suspend_evtchn_release(xce, suspend_evtchn);
+ xc_suspend_evtchn_release(xce, domid, suspend_evtchn);
xc_evtchn_close(xce);
}
break;
On Tue, May 4, 2010 at 10:46 PM, Juergen Gross
<juergen.gross@ts.fujitsu.com> wrote:
> Hi,
>
> latest xen-unstable doesn''t build on my machine:
>
> gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
> -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xen-hptool.o.d
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Werror -I
> ../../tools/python/xen/lowlevel/xc -I ../../tools/libxc -I
> ../../tools/include -c -o xen-hptool.o xen-hptool.c
> xen-hptool.c: In function ‘suspend_guest’:
> xen-hptool.c:136: error: too few arguments to function
> ‘xc_suspend_evtchn_release’
> xen-hptool.c: In function ‘hp_mem_offline_func’:
> xen-hptool.c:231: error: too few arguments to function
> ‘xc_suspend_evtchn_release’
> make[3]: *** [xen-hptool.o] Error 1
> make[3]: Leaving directory `/root/xen-unstable.hg/tools/misc''
>
>
> Juergen
>
> --
> Juergen Gross Principal Developer Operating Systems
> TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
> Fujitsu Technology Solutions e-mail:
> juergen.gross@ts.fujitsu.com
> Domagkstr. 28 Internet: ts.fujitsu.com
> D-80807 Muenchen Company details:
> ts.fujitsu.com/imprint.html
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
--
perception is but an offspring of its own self
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
This is fixed already (in the xen-unstable staging tree at least). -- Keir On 05/05/2010 06:46, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:> Hi, > > latest xen-unstable doesn''t build on my machine: > > gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g > -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value > -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xen-hptool.o.d > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Werror -I > ../../tools/python/xen/lowlevel/xc -I ../../tools/libxc -I ../../tools/include > -c -o xen-hptool.o xen-hptool.c > xen-hptool.c: In function suspend_guest¹: > xen-hptool.c:136: error: too few arguments to function > xc_suspend_evtchn_release¹ > xen-hptool.c: In function hp_mem_offline_func¹: > xen-hptool.c:231: error: too few arguments to function > xc_suspend_evtchn_release¹ > make[3]: *** [xen-hptool.o] Error 1 > make[3]: Leaving directory `/root/xen-unstable.hg/tools/misc'' > > > Juergen_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel