Mark McLoughlin
2007-Mar-07 16:29 UTC
[Xen-devel] [PATCH] [RESEND] Don''t mount raw blktap disks for pygrub
(Doesn''t seem to be in the staging tree; re-sending just in case it slipped through the cracks) Hi, Currently, we mount all blktap disks for pygrub so that it can boot from e.g. QCOW images. However, since pygrub will handle a raw image just fine without mounting through blktap, we shouldn''t bother in that case. Also, it looks like XendDomainInfo.create_vbd() takes the full disk uname rather than the image path. Signed-off-by: Mark McLoughlin <markmc@redhat.com> Cheers, Mark. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Andrew Warfield
2007-Mar-07 16:35 UTC
Re: [Xen-devel] [PATCH] [RESEND] Don''t mount raw blktap disks for pygrub
What is the broken thing that you are trying to fix with this patch? The current code works fine and treats all tap-based devices equally, while this new code special-cases certain tap-based drivers (aio and sync). a. On 3/7/07, Mark McLoughlin <markmc@redhat.com> wrote:> (Doesn''t seem to be in the staging tree; re-sending just in case it > slipped through the cracks) > > Hi, > Currently, we mount all blktap disks for pygrub so that it can boot > from e.g. QCOW images. However, since pygrub will handle a raw image > just fine without mounting through blktap, we shouldn''t bother in that > case. > > Also, it looks like XendDomainInfo.create_vbd() takes the full disk > uname rather than the image path. > > Signed-off-by: Mark McLoughlin <markmc@redhat.com> > > Cheers, > Mark. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel