August 14, 2006, using xen-unstable changeset:
changeset: 11076:f328519053f5
tag: tip
user: kfraser@localhost.localdomain
date: Mon Aug 14 04:58:02 2006 +0100
summary: [XEN] Remove sync_pagetable_state(). No longer needed.
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 (SLES 9 and SLES 10 on IBM HS20 Blades 8843 41U)
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
ISSUES:
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
hs20.sles10-x86_64 | 104 | 7 | 0 | 3 |
hs20.sles9-x86_64 | 103 | 8 | 0 | 3 |
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 105 | 6 | 0 | 3 |
x335sles9 | 103 | 8 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
August 17, 2006, using xen-unstable changeset:
changeset: 11134:ec03b24a2d83
tag: tip
user: shand@kneesaa.uk.xensource.com
date: Tue Aug 15 13:53:55 2006 +0100
summary: Fix VT after hvm changes.
ISSUES: Most testing blocked by issues #740 and 742
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
* Bugzilla Bug 740 x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:
undefined symbol: xc_evtchn_status
* Bugzilla Bug 742 Unable to start xend on sles 9 boxes
x86_32 (SLES 9 on x335 and x235; no PAE support)
Blocked by Bug #742
x86_32 (PAE)
* FC4 on x335
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 (SLES 9 and SLES 10 on IBM HS20 Blades 8843 41U)
Blocked by Bug #740
ISSUES:
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
x335fc4-PAE | 105 | 6 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
August 21, 2006, using xen-unstable changeset:
changeset: 11212:58ed222274f2
tag: tip
user: kfraser@localhost.localdomain
date: Mon Aug 21 03:01:53 2006 +0100
summary: [XEN] Remove unnecessary printk from invalid opcode debug output.
ISSUES:
* Bugzilla Bug 715 xm-test failure - FAIL: 01_migrate_localhost_pos (fails on
RHEL4 and FC6)
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 (SLES 10 on IBM HS20 8843 41U Blade )
ISSUES:
Blocked by Bugzilla Bug 740 x86_64: ImportError:
/usr/lib64/python2.4/xen/lowlevel/xc.so: undefined symbol: xc_evtchn_status
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
hs20.rhel4-PAE | 105 | 5 | 0 | 3 |
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 106 | 5 | 0 | 3 |
x335sles9 | 107 | 4 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
August 22, 2006, using xen-unstable changeset:
changeset: 11218:f681ffc9b01a
tag: tip
user: George Dunlap <dunlapg@umich.edu>
date: Mon Aug 21 11:05:11 2006 -0400
summary: Added option to xentrace to set the trace buffer size.
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 107 | 4 | 0 | 3 |
x335sles9 | 107 | 4 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
August 24, 2006, using xen-unstable changeset:
changeset: 11249:1ff4cc298bec
tag: tip
user: kfraser@localhost.localdomain
date: Thu Aug 24 03:49:41 2006 +0100
summary: [XEN] Fix shadow2 issues with HVM guests.
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
* Bugzilla Bug 740 x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:
undefined symbol: xc_evtchn_status
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64
* SLES 10 on IBM HS20 Blade 8843
ISSUES: BLOCKED
* Bugzilla Bug 740 x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:
undefined symbol: xc_evtchn_status
# uname -a
Linux bl2-10 2.6.16.13-xen #1 SMP Thu Aug 24 07:02:19 CDT 2006 x86_64 x86_64
x86_64 GNU/Linux
# xend start
Traceback (most recent call last):
File "/usr/sbin/xend", line 49, in ?
from xen.xend.server import SrvDaemon
File "//usr/lib64/python/xen/xend/server/SrvDaemon.py", line 17, in
?
import xen.lowlevel.xc
ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: undefined symbol:
xc_bvtsched_domain_get
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 107 | 4 | 0 | 3 |
x335sles9 | 107 | 4 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
August 25, 2006, using xen-unstable changeset:
changeset: 11251:d5eb5205ff35
tag: tip
user: Steven Hand <steven@xensource.com>
date: Thu Aug 24 10:25:49 2006 +0100
summary: Remove redundant performance counters.
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
* Bugzilla Bug 740 x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:
undefined symbol: xc_evtchn_status
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
ISSUES: **BLOCKED
* Bugzilla Bug 740 x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:
undefined symbol: xc_evtchn_status
# uname -a
Linux bl2-10 2.6.16.13-xen #1 SMP Thu Aug 24 07:02:19 CDT 2006 x86_64 x86_64
x86_64 GNU/Linux
# xend start
Traceback (most recent call last):
File "/usr/sbin/xend", line 49, in ?
from xen.xend.server import SrvDaemon
File "//usr/lib64/python/xen/xend/server/SrvDaemon.py", line 17, in ?
import xen.lowlevel.xc
ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: undefined symbol:
xc_bvtsched_domain_get
XM-TEST results summary:
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
August 28, 2006, using xen-unstable changeset:
changeset: 11260:fab84f9c0ce6
tag: tip
user: kaf24@localhost.localdomain
date: Mon Aug 28 06:09:36 2006 +0100
summary: [XEN] Rename shadow2 to shadow and move the various source
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
* x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) by Bugzilla Bug 740 x86_64:
ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: undefined symbol:
xc_evtchn_status
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
ISSUES: **BLOCKED
* Bugzilla Bug 740 x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:
undefined symbol: xc_evtchn_status
# xend start
Traceback (most recent call last):
File "/usr/sbin/xend", line 49, in ?
from xen.xend.server import SrvDaemon
File "//usr/lib64/python/xen/xend/server/SrvDaemon.py", line 17, in
?
import xen.lowlevel.xc
ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: undefined symbol:
xc_bvtsched_domain_get
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 107 | 4 | 0 | 3 |
x335sles9 | 107 | 4 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 28/8/06 3:24 pm, "David F Barrera" <dfbp@us.ibm.com> wrote:> * x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) by Bugzilla Bug 740 > x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: undefined > symbol: xc_evtchn_statusThe string ''xc_evtchn_status'' does not appear anywhere in the current tree. That xc.so python extension is stale. Probably you should just: rm -rf /usr/lib64/python2.4/xen On that machine. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
August 29, 2006, using xen-unstable changeset:
changeset: 11277:a926e72e0491
tag: tip
parent: 11274:20bb80e54f21
parent: 11276:9956c3a3bd84
user: tdeegan@york.uk.xensource.com
date: Tue Aug 29 03:42:35 2006 +0100
summary: Merge
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
* x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) by Bugzilla Bug 740 x86_64:
ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: undefined symbol:
xc_evtchn_status
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
Unable to start xen on this machine. Not sure why. Build log shows:
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272:
warning: missing sentinel in function call
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemu] Error 2
make: *** [all] Error 2
...
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemuinstall] Error 2
make: *** [install] Error 2"
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 107 | 4 | 0 | 3 |
x335sles9 | 107 | 4 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
> ISSUES: > * Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test --Console> run-away (exceeded 131072 bytes) > * x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) by Bugzilla Bug740> x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so:undefined> symbol: xc_evtchn_statusI haven''t heard anyone else mention this. Are you sure it''s not a problem with your install? Perhaps do a ''make uninstall'' on the target machine. Thanks, Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt wrote:>> ISSUES: >> * Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- >> > Console > >> run-away (exceeded 131072 bytes) >> * x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) by Bugzilla Bug >> > 740 > >> x86_64: ImportError: /usr/lib64/python2.4/xen/lowlevel/xc.so: >> > undefined > >> symbol: xc_evtchn_status >> > > I haven''t heard anyone else mention this. Are you sure it''s not a > problem with your install? > > Perhaps do a ''make uninstall'' on the target machine. > > Thanks, > Ian >Ian, Yes, it was fixed yesterday. I inadvertently left that line on the report. -- Regards, David F Barrera Linux Technology Center Systems and Technology Group, IBM "The wisest men follow their own direction. " Euripides _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
August 30, 2006, using xen-unstable changeset:
changeset: 11288:a47951e59cbf
tag: tip
user: Ewan Mellor <ewan@xensource.com>
date: Wed Aug 30 03:47:24 2006 +0100
summary: Shadow memory should be in MiB, not KiB. It also needs rounding up
to be safe.
ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console
run-away (exceeded 131072 bytes)
x86_32 (no PAE support)
* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes
x86_32 (PAE)
* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains
ISSUES:
x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
Unable to start xen on this machine. Build log shows:
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272:
warning: missing sentinel in function call
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemu] Error 2
make: *** [all] Error 2
...
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemuinstall] Error 2
make: *** [install] Error 2"
XM-TEST results summary:
Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
x235-sles9 | 105 | 4 | 0 | 3 |
x335fc4-PAE | 107 | 4 | 0 | 3 |
x335sles9 | 107 | 4 | 0 | 3 |
--
Regards,
David F Barrera
Linux Technology Center
Systems and Technology Group, IBM
"The wisest men follow their own direction. "
Euripides
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Harry Butterworth
2006-Aug-30 16:31 UTC
[Xen-devel] [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
On Wed, 2006-08-30 at 10:58 -0500, David F Barrera wrote:> August 30, 2006, using xen-unstable changeset: > > changeset: 11288:a47951e59cbf> ISSUES: > > x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) > > Unable to start xen on this machine. Build log shows: > > /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call > make[3]: *** [vnc.o] Error 1 > make[2]: *** [subdir-i386-dm] Error 2 > make[1]: *** [ioemu] Error 2 > make: *** [all] Error 2 > ... > make[3]: *** [vnc.o] Error 1 > make[2]: *** [subdir-i386-dm] Error 2 > make[1]: *** [ioemuinstall] Error 2 > make: *** [install] Error 2"This patch should fix your problem here. I have not tested it. Please give it a go and report whether it is OK to be committed to the tree. The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the sentinel needs to be a 64 bit null pointer for the code to be correct. Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
David F Barrera
2006-Aug-30 18:20 UTC
[Xen-devel] Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
Harry Butterworth wrote:> This patch should fix your problem here. I have not tested it. Please > give it a go and report whether it is OK to be committed to the tree. > > The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the > sentinel needs to be a 64 bit null pointer for the code to be correct. > > Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com> > > ------------------------------------------------------------------------ > > diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c > --- a/tools/ioemu/vnc.c Wed Aug 30 10:05:00 2006 > +++ b/tools/ioemu/vnc.c Wed Aug 30 16:23:38 2006 > @@ -1269,7 +1269,7 @@ > exit(1); > > case 0: /* child */ > - execlp("vncviewer", "vncviewer", s, 0); > + execlp("vncviewer", "vncviewer", s, (char *)NULL); > fprintf(stderr, "vncviewer execlp failed\n"); > exit(1); > >Here''s the tail end of what I get: ... XK_Control_Lâ undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847: error: âXK_Alt_Lâ undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: error: âXK_1â undeclared (first use in this function) /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: error: âXK_9â undeclared (first use in this function) make[4]: *** [vnc.o] Error 1 make[4]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'' make[3]: *** [subdir-i386-dm] Error 2 make[3]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'' make[2]: *** [ioemuinstall] Error 2 make[2]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'' make[1]: *** [install] Error 2 make[1]: Leaving directory `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'' make: *** [install-tools] Error 2 -- Regards, David F Barrera Linux Technology Center Systems and Technology Group, IBM "The wisest men follow their own direction. " Euripides _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Harry Butterworth
2006-Aug-31 13:14 UTC
Re: [Xen-devel] Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
On Wed, 2006-08-30 at 13:20 -0500, David F Barrera wrote:> Harry Butterworth wrote: > > This patch should fix your problem here. I have not tested it. Please > > give it a go and report whether it is OK to be committed to the tree. > > > > The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the > > sentinel needs to be a 64 bit null pointer for the code to be correct. > > > > Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com> > > > > ------------------------------------------------------------------------ > > > > diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c > > --- a/tools/ioemu/vnc.c Wed Aug 30 10:05:00 2006 > > +++ b/tools/ioemu/vnc.c Wed Aug 30 16:23:38 2006 > > @@ -1269,7 +1269,7 @@ > > exit(1); > > > > case 0: /* child */ > > - execlp("vncviewer", "vncviewer", s, 0); > > + execlp("vncviewer", "vncviewer", s, (char *)NULL); > > fprintf(stderr, "vncviewer execlp failed\n"); > > exit(1); > > > > > Here''s the tail end of what I get: > > ... > XK_Control_Lâ undeclared (first use in this function) > /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847: > error: âXK_Alt_Lâ undeclared (first use in this function) > /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: > error: âXK_1â undeclared (first use in this function) > /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: > error: âXK_9â undeclared (first use in this function) > make[4]: *** [vnc.o] Error 1 > make[4]: Leaving directory > `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'' > make[3]: *** [subdir-i386-dm] Error 2 > make[3]: Leaving directory > `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'' > make[2]: *** [ioemuinstall] Error 2 > make[2]: Leaving directory > `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'' > make[1]: *** [install] Error 2 > make[1]: Leaving directory > `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'' > make: *** [install-tools] Error 2Well, my patch seems to have fixed your previous compile error so I think it is good. The errors above are unrelated to the patch. The errors above indicate that the symbols XK_Alt_L XK_1 and XK_9 are undefined. (I don''t understand where the weird ''â'' characters are coming from in the error report above). These symbols should be defined in /usr/include/X11/keysymdef.h which is included by vnc.c. Please check that you have this header file installed on your build machine and that the symbols are defined in it. Harry. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Harry Butterworth
2006-Sep-08 16:01 UTC
Re: [Xen-devel] [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
The following code in vnc.c needs to change. I''m not sure if the patch below is the way to change it or if it should be changed in tools/ioemu/patches/vnc-start-vncviewer or in both places. Why is the code checked in in two places? It''s trivial, please commit a fix or explain exactly what is required and I''ll re-spin the patch. Harry. On Wed, 2006-08-30 at 17:31 +0100, Harry Butterworth wrote:> On Wed, 2006-08-30 at 10:58 -0500, David F Barrera wrote: > > August 30, 2006, using xen-unstable changeset: > > > > changeset: 11288:a47951e59cbf > > > ISSUES: > > > > x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843) > > > > Unable to start xen on this machine. Build log shows: > > > > /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call > > make[3]: *** [vnc.o] Error 1 > > make[2]: *** [subdir-i386-dm] Error 2 > > make[1]: *** [ioemu] Error 2 > > make: *** [all] Error 2 > > ... > > make[3]: *** [vnc.o] Error 1 > > make[2]: *** [subdir-i386-dm] Error 2 > > make[1]: *** [ioemuinstall] Error 2 > > make: *** [install] Error 2" > > This patch should fix your problem here. I have not tested it. Please > give it a go and report whether it is OK to be committed to the tree. > > The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the > sentinel needs to be a 64 bit null pointer for the code to be correct. > > Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com> > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel