Hollis Blanchard
2006-Aug-08 23:54 UTC
[Xen-devel] [PATCH] [LIBXC] clean specified files instead of wildcarding
# HG changeset patch # User Hollis Blanchard <hollisb@us.ibm.com> # Date 1155081241 18000 # Node ID fbf4e91468b00b4343e35ac899fd55c1099dd328 # Parent aed85530f3c224821ff3f2b8e4631e56a754729a [LIBXC] clean specified files instead of wildcarding Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> diff -r aed85530f3c2 -r fbf4e91468b0 tools/libxc/Makefile --- a/tools/libxc/Makefile Tue Aug 08 18:37:46 2006 -0500 +++ b/tools/libxc/Makefile Tue Aug 08 18:54:01 2006 -0500 @@ -99,8 +99,9 @@ TAGS: .PHONY: clean clean: - rm -rf *.a *.so* *.o *.opic *.rpm $(LIB) *~ $(DEPS) xen - rm -rf ia64/*.o ia64/*.opic + rm -rf *.rpm $(LIB) *~ $(DEPS) xen \ + $(CTRL_LIB_OBJS) $(CTRL_PIC_OBJS) \ + $(GUEST_LIB_OBJS) $(GUEST_PIC_OBJS) .PHONY: rpm rpm: build _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Aug-09 09:35 UTC
Re: [Xen-devel] [PATCH] [LIBXC] clean specified files instead of wildcarding
On 9/8/06 12:54 am, "Hollis Blanchard" <hollisb@us.ibm.com> wrote:> [LIBXC] clean specified files instead of wildcarding > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>We wildcard in all the other makefiles. Is it a problem here? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hollis Blanchard
2006-Aug-09 15:22 UTC
Re: [Xen-devel] [PATCH] [LIBXC] clean specified files instead of wildcarding
On Wed, 2006-08-09 at 10:35 +0100, Keir Fraser wrote:> > On 9/8/06 12:54 am, "Hollis Blanchard" <hollisb@us.ibm.com> wrote: > > > [LIBXC] clean specified files instead of wildcarding > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> > > We wildcard in all the other makefiles. Is it a problem here?Well yes. The problem is that we''re now adding subdirectories under tools/libxc, so rm -rf *.o doesn''t clean them. The IA64 guys just added rm -rf ia64/*.o, but we shouldn''t need to guess: we already have these handy variables telling us exactly where all the object files are. If you prefer, we can add another unconditional rm -rf powerpc64/* in the IA64 style... -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Aug-09 16:40 UTC
Re: [Xen-devel] [PATCH] [LIBXC] clean specified files instead of wildcarding
On 9/8/06 4:22 pm, "Hollis Blanchard" <hollisb@us.ibm.com> wrote:>> We wildcard in all the other makefiles. Is it a problem here? > > Well yes. The problem is that we''re now adding subdirectories under > tools/libxc, so rm -rf *.o doesn''t clean them. The IA64 guys just added > rm -rf ia64/*.o, but we shouldn''t need to guess: we already have these > handy variables telling us exactly where all the object files are. If > you prefer, we can add another unconditional rm -rf powerpc64/* in the > IA64 style...Okay, your approach is cleaner. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel