Xen devel - Jul 2008 - [PATCH] ioemu-remote: Fix pci pass-through

ioemu-remote: Enable pci pass-through by default.

-- 
Jean Guyader


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Sorry, I missed the Signed-off.

ioemu-remote: Enable pci pass-through by default.

Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>

-- 
Jean Guyader


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

ioemu-remote: Fix the pass-through compilation.

Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>

-- 
Jean Guyader


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hmm, I have already provided fixes for all these patches.  IanJ, it is
part of the patches I''ve sent you.

Jean Guyader, le Tue 15 Jul 2008 17:19:29 +0100, a écrit
:
> diff --git a/xen-hooks.mak b/xen-hooks.mak
> index 4e8b1fa..af977ef 100644
> --- a/xen-hooks.mak
> +++ b/xen-hooks.mak
> @@ -39,11 +39,20 @@ OBJS += tpm_tis.o
>  
>  ifdef CONFIG_STUBDOM
>  CONFIG_PASSTHROUGH=1
> -OBJS += xenfbfront.o
> +else
> +  ifeq (,$(wildcard /usr/include/pci))
> +$(warning *** pciutils-devl package not found - missing /usr/include/pci)
> +$(warning *** PCI passthrough capability has been disabled)
> +  else
> +CONFIG_PASSTHROUGH=1
> +  endif
>  endif
>  
>  ifdef CONFIG_PASSTHROUGH
> -OBJS+= pass-through.o
> +OBJS+= pass-through.o pt-msi.o
> +LIBS += -lpci
> +CFLAGS += -DCONFIG_PASSTHROUGH 
> +$(info *** PCI passthrough capability has been enabled ***)
>  endif
>  
>  BAD_OBJS += gdbstub.o acpi.o apic.o
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Jean Guyader, le Tue 15 Jul 2008 17:25:01 +0100, a écrit
:
> ioemu-remote: Fix the pass-through compilation.
> 
> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
> 
> -- 
> Jean Guyader
> diff --git a/hw/pass-through.c b/hw/pass-through.c
> index bddc203..f29f07d 100644
> --- a/hw/pass-through.c
> +++ b/hw/pass-through.c
> @@ -713,7 +713,7 @@ int pt_init(PCIBus *e_bus, char *direct_pci)
>      dpci_infos.pci_access = pci_access;
>      dpci_infos.e_bus      = e_bus;
>  
> -    if ( strlen(direct_pci) == 0 ) {
> +    if ( !direct_pci || strlen(direct_pci) == 0 ) {
>          return 0;
>      }
>  
> diff --git a/hw/pass-through.h b/hw/pass-through.h
> index ffd87ef..d642be3 100644
> --- a/hw/pass-through.h
> +++ b/hw/pass-through.h
> @@ -27,7 +27,7 @@
>  #define PT_LOGGING_ENABLED
>  
>  #ifdef PT_LOGGING_ENABLED
> -#define PT_LOG(_f, _a...)   fprintf(logfile, "%s: " _f,
__func__, ##_a)
> +#define PT_LOG(_f, _a...)   fprintf(stdout, "%s: " _f, __func__,
##_a)
>  #else
>  #define PT_LOG(_f, _a...)
>  #endif
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Jean Guyader writes ("Re: [Xen-devel] [PATCH] ioemu-remote: Fix pci
pass-through"):
> Sorry, I missed the Signed-off.
> ioemu-remote: Enable pci pass-through by default.
I applied your previous patch and this one and it said this:

/u/iwj/work/qemu-iwj.git/hw/pt-msi.c: In function
''pt_msi_map_update'':
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c:274: warning: format
''%lx'' expects type ''long unsigned int'', but
argument 5 has type ''uint64_t''
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c:274: warning: format
''%lx'' expects type ''long unsigned int'', but
argument 7 has type ''uint64_t''
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c: In function
''pci_msix_writel'':
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c:570: warning: format
''%016lx'' expects type ''long unsigned int'',
but argument 4 has type ''target_phys_addr_t''
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c: In function
''pci_msix_readl'':
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c:619: warning: format
''%016lx'' expects type ''long unsigned int'',
but argument 4 has type ''target_phys_addr_t''
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c: In function
''pt_msix_init'':
/u/iwj/work/qemu-iwj.git/hw/pt-msi.c:726: warning: format
''%lx'' expects type ''long unsigned int'', but
argument 4 has type ''uint64_t''

/u/iwj/work/qemu-iwj.git/hw/pc.c: In function ''pc_init1'':
/u/iwj/work/qemu-iwj.git/hw/pc.c:966: warning: implicit declaration of function
''pt_init''

These should probably be fixed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ian Jackson wrote:
> Jean Guyader writes ("Re: [Xen-devel] [PATCH] ioemu-remote: Fix pci
pass-through"):
>> Sorry, I missed the Signed-off.
>> ioemu-remote: Enable pci pass-through by default.
> 
> I applied your previous patch and this one and it said this:
> 
> [...]
> 
> These should probably be fixed.
> 
I forgot to check the 32 bits compilation, my mistake.
The pt_init declaration error should be fixed with another patch I sent.

ioemu-remote: Fix the pass-through compilation.

Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>

-- 
Jean Guyader


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel