Charles Duffy
2005-Oct-14 13:23 UTC
[Xen-devel] [PATCH] network-bridge script support for multiple external interfaces
The attached patch allows the network-bridge script to be used to generate multiple bridges corresponding to different physical interfaces. It adds a new parameter, "virtnum", used to refer both to the loopback interface to be used and to set defaults regarding the physical interface and bridge name. Thus, if one wishes to start xen-br0 on eth0 and xen-br1 on eth1, one need only call: network-bridge start ## virtnum is 0 by default network-bridge start virtnum=1 ...well, that and set loopback.nloopbacks=2 in the Dom0 kernel parameters. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
David Hopwood
2005-Oct-14 17:02 UTC
Re: [Xen-devel] [PATCH] network-bridge script support for multiple external interfaces
Charles Duffy wrote:> # antispoof Whether to use iptables to prevent spoofing (default yes).[...]> antispoof=${antispoof:-no}The antispoof default is not consistent with the comment. -- David Hopwood <david.nospam.hopwood@blueyonder.co.uk> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Charles Duffy
2005-Oct-15 00:51 UTC
[Xen-devel] Re: [PATCH] network-bridge script support for multiple external interfaces
David Hopwood wrote:> Charles Duffy wrote: >> # antispoof Whether to use iptables to prevent spoofing (default yes). > [...] >> antispoof=${antispoof:-no} > > The antispoof default is not consistent with the comment. >Quite so. (That''s original behavior, though, and so any fix for it should be checked in as a separate changeset -- from my revision-control-nazi days I still have a strong preference for keeping different fixes in different changesets so that they can be merged, accepted or rejected, and otherwise handled individually). _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel