Xen devel - Oct 2006 - Re: [Xen-staging] [xen-unstable] [XEND] Open xend-debug.log in append mode.

Missed this in the [patch] state.
If we are gonna do this can we get a timestamp on every open? or  
every message?
-JX

On Oct 25, 2006, at 5:30 AM, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User kfraser@localhost.localdomain
> # Date 1161768423 -3600
> # Node ID 0c7923eb6b9846c92f1c15486e06ee9745bcf676
> # Parent  410df40afc014555ce7bfcad2852de9e6d0425f0
> [XEND] Open xend-debug.log in append mode.
> Signed-off-by: John Levon <john.levon@sun.com>
> ---
>  tools/python/xen/xend/server/SrvDaemon.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff -r 410df40afc01 -r 0c7923eb6b98 tools/python/xen/xend/server/ 
> SrvDaemon.py
> --- a/tools/python/xen/xend/server/SrvDaemon.py	Wed Oct 25 10:25:18  
> 2006 +0100
> +++ b/tools/python/xen/xend/server/SrvDaemon.py	Wed Oct 25 10:27:03  
> 2006 +0100
> @@ -106,12 +106,12 @@ class Daemon:
>          os.close(2)
>          if XEND_DEBUG:
>              os.open(''/dev/null'', os.O_RDONLY)
> -            os.open(XEND_DEBUG_LOG, os.O_WRONLY|os.O_CREAT)
> +            os.open(XEND_DEBUG_LOG, os.O_WRONLY|os.O_CREAT| 
> os.O_APPEND)
>              os.dup(1)
>          else:
>              os.open(''/dev/null'', os.O_RDWR)
>              os.dup(0)
> -            os.open(XEND_DEBUG_LOG, os.O_WRONLY|os.O_CREAT)
> +            os.open(XEND_DEBUG_LOG, os.O_WRONLY|os.O_CREAT| 
> os.O_APPEND)
>
>
>      def start(self, trace=0):
>
> _______________________________________________
> Xen-staging mailing list
> Xen-staging@lists.xensource.com
> http://lists.xensource.com/xen-staging

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Oct 25, 2006 at 09:01:46AM -0400, Jimi Xenidis wrote:
> Missed this in the [patch] state.
> If we are gonna do this can we get a timestamp on every open? or  
> every message?
Getting a timestamp on every message will be fiddly, because this is just
stderr, and many of the messages come from libxc -- I''d rather put the
work
into getting proper diagnostic efforts into libxc (see the recent thread
discussing just that).

Getting a timestamp on every open would be a doddle -- I''ll do that
now.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 25/10/06 14:01, "Jimi Xenidis" <jimix@watson.ibm.com> wrote:
> Missed this in the [patch] state.
> If we are gonna do this can we get a timestamp on every open? or
> every message?
Well, either it has to be O_TRUNC or O_APPEND. Using neither made no sense
at all for a log file. Timestamp issues are a separate matter.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel