Xen devel - Sep 2006 - [PATCH] [build] Fix xen-unstable build

This patch is needed for a current xen-unstable build to complete.  This
file appears to have been broken for almost two months.

	<b

diff -r 8c29bf7ede67 tools/ioemu/usb-linux.c
--- a/tools/ioemu/usb-linux.c	Thu Sep 21 19:34:45 2006 +0100
+++ b/tools/ioemu/usb-linux.c	Fri Sep 22 08:40:21 2006 -0700
@@ -26,7 +26,6 @@
 #if defined(__linux__)
 #include <dirent.h>
 #include <sys/ioctl.h>
-#include <linux/compiler.h>
 #include <linux/usbdevice_fs.h>
 #include <linux/version.h>
 



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> This patch is needed for a current xen-unstable build to complete.  This
> file appears to have been broken for almost two months.
Obviously not been broken for us - what compiler / distro are you using? 
What arch?

cheers,

S.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, 2006-09-22 at 23:28 +0100, Steven Hand wrote:
> > This patch is needed for a current xen-unstable build to complete. 
This
> > file appears to have been broken for almost two months.
> 
> Obviously not been broken for us - what compiler / distro are you using? 
> What arch?
FC6t3, i386.  I literally just ran "make" in a clean repo,
didn''t diddle
anything.

	<b


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> > > This patch is needed for a current xen-unstable build to 
> > > complete.  
> > > This file appears to have been broken for almost two months.
> > 
> > Obviously not been broken for us - what compiler / distro 
> > are you using? 
> > What arch?
> 
> FC6t3, i386.  I literally just ran "make" in a clean repo, 
> didn''t diddle anything.
Ok thanks - will look into it. 

cheers,

S.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Steven Hand wrote:
>> This patch is needed for a current xen-unstable build to complete. 
This
>> file appears to have been broken for almost two months.
>
> Obviously not been broken for us - what compiler / distro are you 
> using? What arch?
Yeah, it has been broken for me; I just keep removing it without getting 
around to making a patch.  The include is completely bogus anyway.  I 
think it''s in upstream qemu, and it''s bogus there too.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> On Fri, 2006-09-22 at 23:28 +0100, Steven Hand wrote:
> > > This patch is needed for a current xen-unstable build to
complete.
> This
> > > file appears to have been broken for almost two months.
> >
> > Obviously not been broken for us - what compiler / distro are you
using?
> > What arch?
> 
> FC6t3, i386.  I literally just ran "make" in a clean repo,
didn''t
diddle
> anything.
I expect RH have an outstanding patch that fixes the compile error for
their packaging of xen in FC6, but it''s worth mentioning that
you''re
using a pre-release distro with a bleeding edge compiler if you''re
going
to complain about a build error! (or any other bug for that matter)

Thanks,
Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, 2006-09-22 at 23:52 +0100, Ian Pratt wrote:
> I expect RH have an outstanding patch that fixes the compile error for
> their packaging of xen in FC6, but it''s worth mentioning that
you''re
> using a pre-release distro with a bleeding edge compiler if you''re
going
> to complain about a build error! (or any other bug for that matter)
The build breakage didn''t appear to be compiler- or distro-related.  I
guess I was distracted by the thicket of kernel trees, and assumed that
something was trying to include a file from one of those...

	<b


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel