Masaki Kanno
2006-Sep-06 11:49 UTC
[Xen-devel] [PATCH] Add syntax checking for xm block-attach
Hi,
Currently, xm block-attach command doesn''t have syntax checking
about the mode(''r'' or ''w''). Even if wrong
characters to the
mode are specified, VBD is attached to VM with the read-only
mode.
# xm block-list vm1
Vdev BE handle state evt-ch ring-ref BE-path
769 0 0 4 6 8 /local/domain/0/backend/vbd/2/769
# xm block-attach vm1 phy:ram2 hdb1 xyz
# xm block-list vm1
Vdev BE handle state evt-ch ring-ref BE-path
769 0 0 4 6 8 /local/domain/0/backend/vbd/2/769
833 0 0 4 8 585 /local/domain/0/backend/vbd/2/833
This patch adds syntax checking for xm block-attach command.
# xm block-list vm1
Vdev BE handle state evt-ch ring-ref BE-path
769 0 0 4 6 8 /local/domain/0/backend/vbd/2/769
# xm block-attach vm1 phy:ram2 hdb1 xyz
Error: Invalid mode
# xm block-list vm1
Vdev BE handle state evt-ch ring-ref BE-path
769 0 0 4 6 8 /local/domain/0/backend/vbd/2/769
Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Best regards,
Kan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Sep-07 14:55 UTC
Re: [Xen-devel] [PATCH] Add syntax checking for xm block-attach
On Wed, Sep 06, 2006 at 08:49:05PM +0900, Masaki Kanno wrote: Content-Description: Mail message body> Hi, > > Currently, xm block-attach command doesn''t have syntax checking > about the mode(''r'' or ''w''). Even if wrong characters to the > mode are specified, VBD is attached to VM with the read-only > mode.Hi Kan, We also currently use the mode "w!", which means "read-write and it is safe to have multiple writers on this device". Could you respin your patch? Thanks, Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2006-Sep-08 01:14 UTC
Re: [Xen-devel] [PATCH] Add syntax checking for xm block-attach
>On Wed, Sep 06, 2006 at 08:49:05PM +0900, Masaki Kanno wrote: > >Content-Description: Mail message body >> Hi, >> >> Currently, xm block-attach command doesn''t have syntax checking >> about the mode(''r'' or ''w''). Even if wrong characters to the >> mode are specified, VBD is attached to VM with the read-only >> mode. > >Hi Kan, > >We also currently use the mode "w!", which means "read-write and it is >safe to have multiple writers on this device". Could you respin your >patch?Hi Ewan, Thanks for your comment. I will fix this. Best regards, Kan> >Thanks, > >Ewan. > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel