hello Jeremy, Here is a patch to fix few problems in Xen bootloader you sent to the list yesterday. list of changes: - make a dummy tools/pygrub/src/__init__.py - extend filesystem abstraction by adding file_exist() method. this method is used to check for existent of a file given its name. now ext2fs implements this method. - pygrub opens and parses /boot/grub/menu.lst or /boot/grub/grub.conf, in that order. - add /usr/lib/python to system path (see pygrub). without this change, pygrub cannot find grub python package. - remove few blank lines $ diffstat xen-grub.patch __init__.py | 1 fsys/__init__.py | 5 +++- fsys/ext2/ext2module.c | 51 ++++++++++++++++++++++++++++++++++++++++--------- pygrub | 12 +++++++++-- 4 files changed, 57 insertions(+), 12 deletions(-) Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com> I wonder why the patch you sent to list is in CR/LF format? arent you programming on Windows, are you ;-). could you please remove them next time ? regards, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
sorry, I forgot to note that the patch I have just sent to list should be applied on top of the last patch of Jeremy. regards, aq On 4/27/05, aq <aquynh@gmail.com> wrote:> hello Jeremy, > > Here is a patch to fix few problems in Xen bootloader you sent to the > list yesterday. > > list of changes: > - make a dummy tools/pygrub/src/__init__.py > - extend filesystem abstraction by adding file_exist() method. this > method is used to check for existent of a file given its name. now > ext2fs implements this method. > - pygrub opens and parses /boot/grub/menu.lst or /boot/grub/grub.conf, > in that order. > - add /usr/lib/python to system path (see pygrub). without this > change, pygrub cannot find grub python package. > - remove few blank lines > > $ diffstat xen-grub.patch > __init__.py | 1 > fsys/__init__.py | 5 +++- > fsys/ext2/ext2module.c | 51 ++++++++++++++++++++++++++++++++++++++++--------- > pygrub | 12 +++++++++-- > 4 files changed, 57 insertions(+), 12 deletions(-) > > Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com> > > I wonder why the patch you sent to list is in CR/LF format? arent you > programming on Windows, are you ;-). could you please remove them next > time ? > > regards, > aq > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
aq wrote:> hello Jeremy, > > Here is a patch to fix few problems in Xen bootloader you sent to the > list yesterday.The patch had ^M line endings which stopped it applying until I removed them. Please make sure patches don''t have that other operating system''s line endings. Thanks, Mike _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 4/28/05, Mike Wray <mike.wray@hp.com> wrote:> aq wrote: > > hello Jeremy, > > > > Here is a patch to fix few problems in Xen bootloader you sent to the > > list yesterday. > > The patch had ^M line endings which stopped it applying until I removed them. > Please make sure patches don''t have that other operating system''s line endings.Then dont forget to blame Jeremy for this problem. Those ^M are introduced in his first patch. I just inherited his code ;-) Seriously, I will recheck the patch next time. Thanks, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, 2005-04-27 at 18:21 +0900, aq wrote:> Here is a patch to fix few problems in Xen bootloader you sent to the > list yesterday.Thanks. Sorry for the delay in responding, I''ve been underwater with stuff for FC4 test3.> list of changes: > - make a dummy tools/pygrub/src/__init__.pyI still don''t know why this didn''t work, but thanks.> - extend filesystem abstraction by adding file_exist() method. this > method is used to check for existent of a file given its name. now > ext2fs implements this method.Great, thanks. My only comment about the ext2fs code for this is that you might as well inline the contents of ext2_file_exist in ext2fs_file_exist... you don''t gain anything by having that for reuse that I can see.> - pygrub opens and parses /boot/grub/menu.lst or /boot/grub/grub.conf, > in that order. > - add /usr/lib/python to system path (see pygrub). without this > change, pygrub cannot find grub python package.Per the other changes I submitted a week or so ago, you want to append this to the path, not prepend it.> - remove few blank linesFair enough.> $ diffstat xen-grub.patch > __init__.py | 1 > fsys/__init__.py | 5 +++- > fsys/ext2/ext2module.c | 51 ++++++++++++++++++++++++++++++++++++++++--------- > pygrub | 12 +++++++++-- > 4 files changed, 57 insertions(+), 12 deletions(-) > > Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>I''ll apply this to my local tree. Mike -- based on your later mail, should I gather that you''ve applied things to your tree and are in the process of pushing to -unstable? Or should I go about trying to do something more sane to maintain this on the side for a while?> I wonder why the patch you sent to list is in CR/LF format? arent you > programming on Windows, are you ;-). could you please remove them next > time ?Hrmm, I have no clue either. The previous patch appears to not be in DOS format but the second one is. And they should have been exported identically from my local bk repository. I''ll double-check next time before sending. Jeremy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 4/29/05, Jeremy Katz <katzj@redhat.com> wrote:> On Wed, 2005-04-27 at 18:21 +0900, aq wrote: > > Here is a patch to fix few problems in Xen bootloader you sent to the > > list yesterday. > > Thanks. Sorry for the delay in responding, I''ve been underwater with > stuff for FC4 test3. > > > list of changes: > > - make a dummy tools/pygrub/src/__init__.py > > I still don''t know why this didn''t work, but thanks. > > > - extend filesystem abstraction by adding file_exist() method. this > > method is used to check for existent of a file given its name. now > > ext2fs implements this method. > > Great, thanks. My only comment about the ext2fs code for this is that > you might as well inline the contents of ext2_file_exist in > ext2fs_file_exist... you don''t gain anything by having that for reuse > that I can see.I agree. By the way, I am working on xfs/jfs/reiserfs module for this code. Hopefully I will finish soon. regards, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Katz wrote:> On Wed, 2005-04-27 at 18:21 +0900, aq wrote: > >>Here is a patch to fix few problems in Xen bootloader you sent to the >>list yesterday. > > Thanks. Sorry for the delay in responding, I''ve been underwater with > stuff for FC4 test3. > >>list of changes: >>- make a dummy tools/pygrub/src/__init__.py > > I still don''t know why this didn''t work, but thanks. > >>- extend filesystem abstraction by adding file_exist() method. this >>method is used to check for existent of a file given its name. now >>ext2fs implements this method. > > Great, thanks. My only comment about the ext2fs code for this is that > you might as well inline the contents of ext2_file_exist in > ext2fs_file_exist... you don''t gain anything by having that for reuse > that I can see. > >>- pygrub opens and parses /boot/grub/menu.lst or /boot/grub/grub.conf, >>in that order. >>- add /usr/lib/python to system path (see pygrub). without this >>change, pygrub cannot find grub python package. > > Per the other changes I submitted a week or so ago, you want to append > this to the path, not prepend it. > > >>- remove few blank lines > > > Fair enough. > >>$ diffstat xen-grub.patch >> __init__.py | 1 >> fsys/__init__.py | 5 +++- >> fsys/ext2/ext2module.c | 51 ++++++++++++++++++++++++++++++++++++++++--------- >> pygrub | 12 +++++++++-- >> 4 files changed, 57 insertions(+), 12 deletions(-) >> >>Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com> > > > I''ll apply this to my local tree. Mike -- based on your later mail, > should I gather that you''ve applied things to your tree and are in the > process of pushing to -unstable? Or should I go about trying to do > something more sane to maintain this on the side for a while?Yes, I''ve applied the patch and it should be making its way out to unstable, possibly today. BTW, I had to install e2fsprogs-devel before it would compile, so I added a note that you need that in a README.>>I wonder why the patch you sent to list is in CR/LF format? arent you >>programming on Windows, are you ;-). could you please remove them next >>time ? > > > Hrmm, I have no clue either. The previous patch appears to not be in > DOS format but the second one is. And they should have been exported > identically from my local bk repository. I''ll double-check next time > before sending.Mike _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, 2005-04-29 at 08:59 +0100, Mike Wray wrote:> Yes, I''ve applied the patch and it should be making its way out > to unstable, possibly today.Cool, thanks.> BTW, I had to install e2fsprogs-devel before it would compile, so > I added a note that you need that in a README.When other fsystems come along, we''ll probably end up wanting to check for availability of the libraries and only build support for the filesystems that we can. Unfortunately, I''m going to have to look harder at distutils to see if there is a clean way to do that :) Jeremy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 4/29/05, Mike Wray <mike.wray@hp.com> wrote:> Jeremy Katz wrote: > > On Wed, 2005-04-27 at 18:21 +0900, aq wrote: > > > >>Here is a patch to fix few problems in Xen bootloader you sent to the > >>list yesterday. > > > > Thanks. Sorry for the delay in responding, I''ve been underwater with > > stuff for FC4 test3. > > > >>list of changes: > >>- make a dummy tools/pygrub/src/__init__.py > > > > I still don''t know why this didn''t work, but thanks. > > > >>- extend filesystem abstraction by adding file_exist() method. this > >>method is used to check for existent of a file given its name. now > >>ext2fs implements this method. > > > > Great, thanks. My only comment about the ext2fs code for this is that > > you might as well inline the contents of ext2_file_exist in > > ext2fs_file_exist... you don''t gain anything by having that for reuse > > that I can see. > > > >>- pygrub opens and parses /boot/grub/menu.lst or /boot/grub/grub.conf, > >>in that order. > >>- add /usr/lib/python to system path (see pygrub). without this > >>change, pygrub cannot find grub python package. > > > > Per the other changes I submitted a week or so ago, you want to append > > this to the path, not prepend it. > > > > > >>- remove few blank lines > > > > > > Fair enough. > > > >>$ diffstat xen-grub.patch > >> __init__.py | 1 > >> fsys/__init__.py | 5 +++- > >> fsys/ext2/ext2module.c | 51 ++++++++++++++++++++++++++++++++++++++++--------- > >> pygrub | 12 +++++++++-- > >> 4 files changed, 57 insertions(+), 12 deletions(-) > >> > >>Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com> > > > > > > I''ll apply this to my local tree. Mike -- based on your later mail, > > should I gather that you''ve applied things to your tree and are in the > > process of pushing to -unstable? Or should I go about trying to do > > something more sane to maintain this on the side for a while? > > Yes, I''ve applied the patch and it should be making its way out > to unstable, possibly today.Mike, will you push those code to -unstable soon? I am looking forward to it. ( I am having few improvements, but not sure what to patch against) thank you, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
aq wrote:>... > Mike, will you push those code to -unstable soon? I am looking forward > to it. ( I am having few improvements, but not sure what to patch > against) >I''ve applied the patch and some of your fixes locally. It''s in the pipeline for unstable, I can''t push directly myself. Mike _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel