Mike D. Day
2005-Apr-18 21:21 UTC
[Xen-devel] [PATCH] optionally skip ioemu in tools build
I''m not sure if this has been discussed already, but I think it should be the default to skip building tools/ioemu. Skipping ioemu solves the problems associated with building on machines that do not have X, and saves time for developers who do not need io emulation. Attached patch to tools/Makefile will skip ioemu by default unless the BUILD_IOEMU environment variable is set. signed-off-by: Mike D. Day <ncmike@us.ibm.com> -- Mike D. Day STSM and Architect, Open Virtualization IBM Linux Technology Center 3039 Cornwallis Road Research Triangle Park, NC 27709 Phone: (919) 543-4283 ncmike@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt
2005-Apr-18 23:03 UTC
RE: [Xen-devel] [PATCH] optionally skip ioemu in tools build
> I''m not sure if this has been discussed already, but I think > it should be the default to skip building tools/ioemu. > Skipping ioemu solves the problems associated with building > on machines that do not have X, and saves time for developers > who do not need io emulation. Attached patch to > tools/Makefile will skip ioemu by default unless the > BUILD_IOEMU environment variable is set.I think my preference would be to do a full build by default, so we get alerted to build failures sooner rather than later. I know there aren''t too many VT-x users right now, but it''s going to be an important part of Xen in a few months time when the boxes start shipping. It takes 20 seconds to build ioemu on my machine, so its not really slowing the build cycle down very much. Perhaps we should just have a patch that skips it if the host doesn''t have X or g++ ? Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Adam Heath
2005-Apr-18 23:22 UTC
RE: [Xen-devel] [PATCH] optionally skip ioemu in tools build
On Tue, 19 Apr 2005, Ian Pratt wrote:> > I''m not sure if this has been discussed already, but I think > > it should be the default to skip building tools/ioemu. > > Skipping ioemu solves the problems associated with building > > on machines that do not have X, and saves time for developers > > who do not need io emulation. Attached patch to > > tools/Makefile will skip ioemu by default unless the > > BUILD_IOEMU environment variable is set. > > I think my preference would be to do a full build by default, so we get > alerted to build failures sooner rather than later. I know there aren''t > too many VT-x users right now, but it''s going to be an important part of > Xen in a few months time when the boxes start shipping. It takes 20 > seconds to build ioemu on my machine, so its not really slowing the > build cycle down very much. > > Perhaps we should just have a patch that skips it if the host doesn''t > have X or g++ ?Er, unless you are linking to features used by those tools, then don''t skip it. Think cross-compiling, etc. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Michael Day
2005-Apr-19 12:31 UTC
RE: [Xen-devel] [PATCH] optionally skip ioemu in tools build
On Mon, 2005-04-18 at 18:22 -0500, Adam Heath wrote:> > Perhaps we should just have a patch that skips it if the host doesn''t > > have X or g++ ? > > Er, unless you are linking to features used by those tools, then don''t skip > it. Think cross-compiling, etc.How about inverting the original patch to build ioemu by default, but skipping ioemu if a variable is defined. That way a developer can skip ioemu but must explicitly take action to do so. Mike signed-off-by: Mike Day <md@soft-hackle.net> //------------------------------------------------------------// Mike Day md@soft-hackle.net //------------------------------------------------------------// _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt
2005-Apr-19 12:37 UTC
RE: [Xen-devel] [PATCH] optionally skip ioemu in tools build
> > Er, unless you are linking to features used by those tools, > then don''t > > skip it. Think cross-compiling, etc. > > How about inverting the original patch to build ioemu by > default, but skipping ioemu if a variable is defined. That > way a developer can skip ioemu but must explicitly take > action to do so.Sure, will apply. Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel