Jeremy Katz
2005-Apr-15 20:36 UTC
[Xen-devel] [PATCH] Make non-native python path handling a fallback
Although I don''t really agree with the installing of the python bits to the non-native paths, I can see where it''s useful as long as the module ABI doesn''t change if you''re trying to distribute binary tarballs. But with the current handling it adds module lookup costs for the native path case (which would be the norm) as well as prevents using PYTHONPATH to look to a different location for the modules. The attached patch changes things so that at first, the xen module is attempted to be imported from the stock paths. If we get an ImportError exception, then it adds /usr/lib/python to the end of the python path and imports again. Signed-off-by: Jeremy Katz <katzj@redhat.com> Jeremy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt
2005-Apr-15 20:58 UTC
RE: [Xen-devel] [PATCH] Make non-native python path handling a fallback
> Although I don''t really agree with the installing of the > python bits to the non-native paths, I can see where it''s > useful as long as the module ABI doesn''t change if you''re > trying to distribute binary tarballs. But with the current > handling it adds module lookup costs for the native path case > (which would be the norm) as well as prevents using > PYTHONPATH to look to a different location for the modules. > > The attached patch changes things so that at first, the xen > module is attempted to be imported from the stock paths. If > we get an ImportError exception, then it adds /usr/lib/python > to the end of the python path and imports again.Do you prefer this to just unconditionally addding /usr/lib/python to the end of the path rather than the front? Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Katz
2005-Apr-15 21:08 UTC
RE: [Xen-devel] [PATCH] Make non-native python path handling a fallback
On Fri, 2005-04-15 at 21:58 +0100, Ian Pratt wrote:> > Although I don''t really agree with the installing of the > > python bits to the non-native paths, I can see where it''s > > useful as long as the module ABI doesn''t change if you''re > > trying to distribute binary tarballs. But with the current > > handling it adds module lookup costs for the native path case > > (which would be the norm) as well as prevents using > > PYTHONPATH to look to a different location for the modules. > > > > The attached patch changes things so that at first, the xen > > module is attempted to be imported from the stock paths. If > > we get an ImportError exception, then it adds /usr/lib/python > > to the end of the python path and imports again. > > Do you prefer this to just unconditionally addding /usr/lib/python to > the end of the path rather than the front?Slightly, but just because having /usr/lib/python in my sys.path is ugly :-) I can look over it, though... patch doing that attached Signed-off-by: Jeremy Katz <katzj@redhat.com> Jeremy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel