Christoph Hellwig
2004-Nov-23 02:31 UTC
[Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src
On Mon, Nov 22, 2004 at 09:37:19PM -0600, svn-commits@oss.oracle.com wrote:> Author: mfasheh > Date: 2004-11-22 21:37:18 -0600 (Mon, 22 Nov 2004) > New Revision: 1663 > > Modified: > branches/dlm-glue/src/journal.c > branches/dlm-glue/src/namei.c > branches/dlm-glue/src/ocfs.h > branches/dlm-glue/src/super.c > Log: > * ocfs_malloc was hardly used so lets take this opportunity to get rid of it.You never opencode the memset ocfs_malloc did. Did you do an audit that it's never needed?
Mark Fasheh
2004-Nov-23 02:58 UTC
[Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src
On Tue, Nov 23, 2004 at 09:30:52AM +0100, Christoph Hellwig wrote:> You never opencode the memset ocfs_malloc did. Did you do an audit that > it's never needed?Yeah, stupidly, much of the code which called ocfs_malloc did the memset anyway so that's why you don't see any "+ memset( ..." lines in the patch :) --Mark -- Mark Fasheh Software Developer, Oracle Corp mark.fasheh@oracle.com
Maybe Matching Threads
- [PATCH 1/6] Add dlm operations placeholders
- [patch 07/22] ocfs2: dlm_request_all_locks() should deal with the status sent from target node
- Backport patches to ocfs2 1.4 tree from mainline
- [PATCH 0/62] Ocfs2 updates for 2.6.26-rc1
- [PATCH 1/1] ocfs2: Add missing iput() during error handling in ocfs2_dentry_attach_lock()