openssh bugs - Mar 2009 - [Bug 1570] New: Incorrect return code if mux master has completed

https://bugzilla.mindrot.org/show_bug.cgi?id=1570

           Summary: Incorrect return code if mux master has completed
           Product: Portable OpenSSH
           Version: 5.2p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: peter.oliver at eon-is.co.uk


When a control master is running because it still has clients, but the
command that that master originally ran has already exited, a client
will incorrectly exit 255.  It will otherwise work correctly.
> cat ~/.ssh/config
ControlMaster   auto
ControlPath     ~/.ssh/mux/%r@%h:%p
> ssh -f remote-host sleep 60
Password: 
> ssh -n remote-host sleep 300 &
[3] 9166
> ssh -vv remote-host date
OpenSSH_5.1p1, OpenSSL 0.9.8g 19 Oct 2007
debug1: Reading configuration data /home/xxx/.ssh/config
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: auto-mux: Trying existing master
Tue Mar 10 12:31:01 GMT 2009
debug2: Received EOF from master
debug2: Received exit status from master 0
> echo $?
0
> sleep 60
> ssh -vv remote-host date
OpenSSH_5.1p1, OpenSSL 0.9.8g 19 Oct 2007
debug1: Reading configuration data /home/xxx/.ssh/config
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: auto-mux: Trying existing master
Tue Mar 10 12:32:14 GMT 2009
debug2: Received EOF from master
debug2: Control master terminated unexpectedly
> echo $?
255

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1570





--- Comment #1 from Peter Oliver <peter.oliver at eon-is.co.uk> 
2009-03-14 04:34:46 ---
Created an attachment (id=1617)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1617)
vs 5.2p1 - Don't recycle channel id 0

The attached patch prevents channel id 0 from being reused.  This
causes client_input_channel_req to correctly forward the exit value to
the mux client.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1570

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1617|0                           |1
        is obsolete|                            |

--- Comment #2 from Damien Miller <djm at mindrot.org> 2009-11-10 13:48:02
EST ---
Created an attachment (id=1719)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1719)
prefer to dispatch exit statuses via mux control fd

I think this approach is better: this implicitly identifies mux
channels that have recycled the initial session ID by preferring to
dispatch exit statuses via ones that have a control FD (i.e. mux
channels) to ones that don't (i.e. the initial session).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1570

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1626

--- Comment #3 from Damien Miller <djm at mindrot.org> 2009-11-10 13:48:19
EST ---
Put this on the list for openssh-5.4

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1570

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1719|                            |ok+
               Flag|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1570

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Damien Miller <djm at mindrot.org> 2009-11-17 16:32:16
EST ---
patch applied. The fix will be in OpenSSH 5.4 - thanks for the detailed
report.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1570

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> 2010-03-26
10:51:15 EST ---
With the release of 5.4p1, this bug is now considered closed.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.