Me and Dennis Kasprzyk changed CompRect to be more intuitive and easily replace XRectangle use. This patch changes CompRect and whole Core. Thanks for attention. -- Eduardo Gurgel Pinho (GELSoL-UFC) (Gentoo) Linux User #415930 http://edgurgel.wordpress.com http://alu.dc.ufc.br/~eduardo -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.freedesktop.org/archives/compiz/attachments/20090301/0d123eff/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Better-definition-to-CompRect.patch Type: application/octet-stream Size: 43622 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20090301/0d123eff/attachment-0001.obj
On Mon, Mar 2, 2009 at 12:13 AM, Eduardo Gurgel <edgurgel at gmail.com> wrote:> Me and Dennis Kasprzyk changed CompRect to be more intuitive and easily > replace XRectangle use. > > This patch changes CompRect and whole Core. > > Thanks for attention. > > -- > Eduardo Gurgel Pinho > (GELSoL-UFC) > > (Gentoo) Linux User #415930 > http://edgurgel.wordpress.com > http://alu.dc.ufc.br/~eduardo >For those who are concerned, the plugins that use CompRect (or XRectangle) are: * Tile * Maximumize * Put * Wall * Snap * ExtramWM? If this patch is OK with onestone, can it be commited? The rest of the plugins that use this functionality can be adapted fairly quickly. Cheers, Sam> _______________________________________________ > compiz mailing list > compiz at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/compiz > >-- Sam Spilsbury
On Sun, Mar 1, 2009 at 1:29 PM, Sam Spilsbury <smspillaz at gmail.com> wrote:> On Mon, Mar 2, 2009 at 12:13 AM, Eduardo Gurgel <edgurgel at gmail.com> > wrote: > > Me and Dennis Kasprzyk changed CompRect to be more intuitive and easily > > replace XRectangle use. > > > > This patch changes CompRect and whole Core. > > > > Thanks for attention. > > > > -- > > Eduardo Gurgel Pinho > > (GELSoL-UFC) > > > > (Gentoo) Linux User #415930 > > http://edgurgel.wordpress.com > > http://alu.dc.ufc.br/~eduardo <http://alu.dc.ufc.br/%7Eeduardo> > > > > For those who are concerned, the plugins that use CompRect (or XRectangle) > are: > * Tile > * Maximumize > * Put > * Wall > * Snap > * ExtramWM?Put, Maximumize and Wall already ported. Just waiting approval or not. But, what about BOX usage? Should we replace it by CompRect right?> > > If this patch is OK with onestone, can it be commited? The rest of the > plugins that use this functionality can be adapted fairly quickly. > > Cheers, > > Sam > > > > _______________________________________________ > > compiz mailing list > > compiz at lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/compiz > > > > > > > > -- > Sam Spilsbury >-- Eduardo Gurgel Pinho (GELSoL-UFC) (Gentoo) Linux User #415930 http://edgurgel.wordpress.com http://alu.dc.ufc.br/~eduardo -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.freedesktop.org/archives/compiz/attachments/20090301/1ae93bff/attachment.html
On Tue, Mar 3, 2009 at 7:12 AM, Sam Spilsbury <smspillaz at gmail.com> wrote:> On Mon, Mar 2, 2009 at 9:05 PM, Danny Baumann <dannybaumann at web.de> wrote: >> Hi, >> >>> >> Personally, I'd like to see x1/y1/x2/y2 instead of >>> >> left/top/right/bottom. The reason is that while left etc. is the >>> >> somewhat clearer term, x1 etc. is the more commonly used term for >>> >> defining rectangles. >>> > >>> > Oh, and what I forgot: Wouldn't it be a good idea to derive >>> > CompWindow::Geometry from CompRect? After all, CompWindow::Geometry is >>> > just the window rectangle + border size handling. >>> > >>> > (and on a slightly related question, wouldn't it also be a good idea to >>> > add a function that returns a CompRect with window size including frame >>> > to CompWindow?) >>> > >> >>> I don't know if such a function exists. But it would be nice to add >>> functions that return a BOX, Box, XRectangle and Region. We need to >>> use these for X.org functions. >> >> Do you have any specific Xlib functions that would need that in mind? >I'm not particularly sure of any use cases right now, but I think it could end up being a useful point in there are some. Of course, such changes can always be delayed until plugins actually need them.> >> >>> Also, doesn't eduardo's patch cover place.cpp? >> >> Nope, it doesn't. It's no problem though, I'll convert it. >> >> Regards, >> >> Danny >> >> > > > > -- > Sam Spilsbury >Regards, Sam -- Sam Spilsbury