David Blaikie via llvm-dev
2021-Oct-26 19:52 UTC
[llvm-dev] dexter failures in cross-project-tests
I'm trying to add some test coverage to cross-project-tests (related to the simplified template names work), and figured I'd start by making sure everything passes. I fixed some pretty printer issues (a36032345ed823414fcee0f9aed43628f4320001 - though that makes me wonder: is any buildbot running these tests, because they look like they've been failing for a while?) and then some dexter issues. Anyone know what these dexter failures are about? The first one doesn't even seem to have the command line arguments right, which seems concerning/like something's quite broken. The second one gives not much meaningful/actionable output - and I tried running dexter directly with --verbose and seeing what it was doing (it didn't print much, but said it couldn't print the value of a local variable when it was passed to printf?), tried building the binary with the cflags that are passed to dexter and the binary ran correctly/was debuggable/I could print the value of the variable - seems like dexter could be more informative both while running under lit/the default configuration, and otherwise? FAIL: cross-project-tests :: debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex (62 of 104) ******************** TEST 'cross-project-tests :: debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex' FAILED ******************** Script: -- : 'RUN: at line 7'; /usr/local/google/home/blaikie/dev/llvm/build/default/bin/clang /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/test.cpp -O0 -g -o /usr/local/google/home/blaikie/dev/llvm/build/default/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/Output/commands.dex.tmp : 'RUN: at line 8'; "/usr/bin/python3.9" "/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/dexter.py" test --fail-lt 1.0 -w --builder clang --debugger lldb --cflags "-O0 -glldb" --binary /usr/local/google/home/blaikie/dev/llvm/build/default/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/Output/commands.dex.tmp /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex | /usr/local/google/home/blaikie/dev/llvm/build/default/bin/FileCheck /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex -- Exit Code: 2 Command Output (stderr): -- error: argument --binary: not allowed with argument --builder usage: DExTer test [-h] [--no-color-output] [--time-report] [-v] [-V] [-w] [--unittest {off,show-failures,show-all}] [--working-directory <file>] [--save-temps] [--fail-lt <float>] [--calculate-average] (--binary <file> | --builder {clang,clang-c,gcc} | --vs-solution <file>) [--cflags CFLAGS] [--ldflags LDFLAGS] [--lldb-executable <file>] --debugger {dbgeng,lldb,vs2015,vs2017,vs2019} [--max-steps <int>] [--pause-between-steps <seconds>] [--show-debugger] [--arch <architecture>] [--source-root-dir <directory>] [--debugger-use-relative-paths] [--penalty-variable-optimized <int>] [--penalty-misordered-values <int>] [--penalty-irretrievable <int>] [--penalty-not-evaluatable <int>] [--penalty-missing-values <int>] [--penalty-incorrect-values <int>] [--penalty-unreachable <int>] [--penalty-misordered-steps <int>] [--penalty-missing-step <int>] [--penalty-incorrect-program-state <int>] [--results-directory <directory>] [<test-path>] FileCheck error: '<stdin>' is empty. FileCheck command line: /usr/local/google/home/blaikie/dev/llvm/build/default/bin/FileCheck /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex -- ******************** FAIL: cross-project-tests :: debuginfo-tests/dexter/feature_tests/subtools/test/source-root-dir.cpp (91 of 104) ******************** TEST 'cross-project-tests :: debuginfo-tests/dexter/feature_tests/subtools/test/source-root-dir.cpp' FAILED ******************** Script: -- : 'RUN: at line 4'; "/usr/bin/python3.9" "/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/dexter.py" test --lldb-executable "/usr/local/google/home/blaikie/dev/llvm/build/default/bin/lldb" --fail-lt 1.0 -w --builder 'clang' --debugger 'lldb' --cflags "-O0 -glldb -fdebug-prefix-map=/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test=/changed" --source-root-dir=/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test --debugger-use-relative-paths -- /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/source-root-dir.cpp -- Exit Code: 2 Command Output (stdout): -- source-root-dir.cpp: (0.1429) -- ******************** -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211026/b158ffd0/attachment.html>
Stephen is on holiday for a couple of weeks; I’ve pinged some people internally who should be able to help. --paulr From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of David Blaikie via llvm-dev Sent: Tuesday, October 26, 2021 3:53 PM To: llvm-dev <llvm-dev at lists.llvm.org>; James Henderson <jh7370.2008 at my.bristol.ac.uk>; Tozer, Stephen <stephen.tozer at sony.com> Subject: [llvm-dev] dexter failures in cross-project-tests I'm trying to add some test coverage to cross-project-tests (related to the simplified template names work), and figured I'd start by making sure everything passes. I fixed some pretty printer issues (a36032345ed823414fcee0f9aed43628f4320001 - though that makes me wonder: is any buildbot running these tests, because they look like they've been failing for a while?) and then some dexter issues. Anyone know what these dexter failures are about? The first one doesn't even seem to have the command line arguments right, which seems concerning/like something's quite broken. The second one gives not much meaningful/actionable output - and I tried running dexter directly with --verbose and seeing what it was doing (it didn't print much, but said it couldn't print the value of a local variable when it was passed to printf?), tried building the binary with the cflags that are passed to dexter and the binary ran correctly/was debuggable/I could print the value of the variable - seems like dexter could be more informative both while running under lit/the default configuration, and otherwise? FAIL: cross-project-tests :: debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex (62 of 104) ******************** TEST 'cross-project-tests :: debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex' FAILED ******************** Script: -- : 'RUN: at line 7'; /usr/local/google/home/blaikie/dev/llvm/build/default/bin/clang /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/test.cpp -O0 -g -o /usr/local/google/home/blaikie/dev/llvm/build/default/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/Output/commands.dex.tmp : 'RUN: at line 8'; "/usr/bin/python3.9" "/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/dexter.py" test --fail-lt 1.0 -w --builder clang --debugger lldb --cflags "-O0 -glldb" --binary /usr/local/google/home/blaikie/dev/llvm/build/default/projects/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/Output/commands.dex.tmp /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex | /usr/local/google/home/blaikie/dev/llvm/build/default/bin/FileCheck /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex -- Exit Code: 2 Command Output (stderr): -- error: argument --binary: not allowed with argument --builder usage: DExTer test [-h] [--no-color-output] [--time-report] [-v] [-V] [-w] [--unittest {off,show-failures,show-all}] [--working-directory <file>] [--save-temps] [--fail-lt <float>] [--calculate-average] (--binary <file> | --builder {clang,clang-c,gcc} | --vs-solution <file>) [--cflags CFLAGS] [--ldflags LDFLAGS] [--lldb-executable <file>] --debugger {dbgeng,lldb,vs2015,vs2017,vs2019} [--max-steps <int>] [--pause-between-steps <seconds>] [--show-debugger] [--arch <architecture>] [--source-root-dir <directory>] [--debugger-use-relative-paths] [--penalty-variable-optimized <int>] [--penalty-misordered-values <int>] [--penalty-irretrievable <int>] [--penalty-not-evaluatable <int>] [--penalty-missing-values <int>] [--penalty-incorrect-values <int>] [--penalty-unreachable <int>] [--penalty-misordered-steps <int>] [--penalty-missing-step <int>] [--penalty-incorrect-program-state <int>] [--results-directory <directory>] [<test-path>] FileCheck error: '<stdin>' is empty. FileCheck command line: /usr/local/google/home/blaikie/dev/llvm/build/default/bin/FileCheck /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/precompiled_binary/commands.dex -- ******************** FAIL: cross-project-tests :: debuginfo-tests/dexter/feature_tests/subtools/test/source-root-dir.cpp (91 of 104) ******************** TEST 'cross-project-tests :: debuginfo-tests/dexter/feature_tests/subtools/test/source-root-dir.cpp' FAILED ******************** Script: -- : 'RUN: at line 4'; "/usr/bin/python3.9" "/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/dexter.py" test --lldb-executable "/usr/local/google/home/blaikie/dev/llvm/build/default/bin/lldb" --fail-lt 1.0 -w --builder 'clang' --debugger 'lldb' --cflags "-O0 -glldb -fdebug-prefix-map=/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test=/changed" --source-root-dir=/usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test --debugger-use-relative-paths -- /usr/local/google/home/blaikie/dev/llvm/src/cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/source-root-dir.cpp -- Exit Code: 2 Command Output (stdout): -- source-root-dir.cpp: (0.1429) -- ******************** -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211027/279286a4/attachment.html>
Hi David,> I'm trying to add some test coverage to cross-project-tests (related to the simplified template names work), and figured I'd start by making sure everything passes. I fixed some pretty printer issues (a36032345ed823414fcee0f9aed43628f4320001 - though that makes me wonder: is any buildbot running these tests, because they look like they've been failing for a while?) and then some dexter issues.Apple's lldb bot (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake) runs the cross-project-tests. Looking at it now though, it looks like the job status isn't affected by these tests if they fail, a bunch of the dexter feature_tests appear to contain "UNSUPPORTED: system-darwin", plus - picking a "passing" build (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37155) - a load of dexter tests fail due to environment issues. All in all I'd say that doesn't really count, and I'm not aware of any other bots running these tests.> Anyone know what these dexter failures are about? The first one doesn't even seem to have the command line arguments right, which seems concerning/like something's quite broken. The second one gives not much meaningful/actionable output - and I tried running dexter directly with --verbose and seeing what it was doing (it didn't print much, but said it couldn't print the value of a local variable when it was passed to printf?), tried building the binary with the cflags that are passed to dexter and the binary ran correctly/was debuggable/I could print the value of the variable - seems like dexter could be more informative both while running under lit/the default configuration, and otherwise?Looks like the first test fails because of changes in D109833 - I've put a fix up here D112624. I'm not sure about the second failure without digging in deeper. One of us (cc Tom, Jeremy) can possibly take a look on or after Friday - we could XFAIL it until we get the chance? N.B. Stephen is away at the moment. Thanks, Orlando -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211027/f3fbfd86/attachment.html>