thr3ads.net - llvm dev - [llvm-dev] How to submit a series of patches in a single review [Dec 2021]

If this information is useful, please help other people find it:
Share via:

shaka via llvm-dev

2021-Dec-10 11:47 UTC

[llvm-dev] How to submit a series of patches in a single review

Thanks, Fraser. That sounds good.&nbsp;David just proposed the same
solution. I will try.
But it would really help if there are any documents addressing this.

------------------ Original ------------------
From: Fraser Cormack <fraser at codeplay.com&gt;
Date: Fri,Dec 10,2021 7:39 PM
To: 447521189 at qq.com <447521189 at qq.com&gt;, llvm-dev at
lists.llvm.org <llvm-dev at lists.llvm.org&gt;
Subject: Re: [llvm-dev] How to submit a series of patches in a single review



Hi Shaka,

I just taught someone else how to do this morning!

What I do first is option 2 to get 2 separate reviews, then navigate to
the web interface for 'B' and click "Edit Related Revisions"
-&gt; "Edit
Parent Revisions" -&gt; <click A&gt;.

This creates a patch "stack" which is what you're after.

I agree it's not very well documented: it took me a while to work out
what to do. Do people think we should add some documentation to this
effect?

Thanks,
Fraser

On Fri, 2021-12-10 at 19:28 +0800, shaka via llvm-dev wrote:
&gt; Hi all,
&gt; 
&gt; I'm new for community contribution and I wonder is there a way to
&gt; submit patch series in a single review?
&gt; For example I have 2 patches: A and B. B depends on A. How can I
&gt; submit them together?
&gt; 1. The Web interface (
&gt;
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
&gt; ) seems doesn't allow uploading multiple patches.
&gt; 2. I also tried the command line tool arc (
&gt;
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
&gt; ) by invoking `arc diff HEAD~` on each commit.
&gt;&nbsp;&nbsp; &nbsp; But these produce 2 seperate reviews and
lose dependency.
&gt; 
&gt; Any advice?
&gt; 
&gt; Best regards,
&gt; Shaka
&gt; _______________________________________________
&gt; LLVM Developers mailing list
&gt; llvm-dev at lists.llvm.org
&gt; 
&gt; https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
&gt;
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211210/eb5e3336/attachment.html>

David Spickett via llvm-dev

2021-Dec-10 12:13 UTC

head link

[llvm-dev] How to submit a series of patches in a single review

I will write up something to go after
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
and post for review.

On Fri, 10 Dec 2021 at 11:47, shaka via llvm-dev
<llvm-dev at lists.llvm.org> wrote:>
> Thanks, Fraser. That sounds good. David just proposed the same solution. I
will try.
> But it would really help if there are any documents addressing this.
>
> ------------------ Original ------------------
> From: Fraser Cormack <fraser at codeplay.com>
> Date: Fri,Dec 10,2021 7:39 PM
> To: 447521189 at qq.com <447521189 at qq.com>, llvm-dev at
lists.llvm.org <llvm-dev at lists.llvm.org>
> Subject: Re: [llvm-dev] How to submit a series of patches in a single
review
>
> Hi Shaka,
>
> I just taught someone else how to do this morning!
>
> What I do first is option 2 to get 2 separate reviews, then navigate to
> the web interface for 'B' and click "Edit Related
Revisions" -> "Edit
> Parent Revisions" -> <click A>.
>
> This creates a patch "stack" which is what you're after.
>
> I agree it's not very well documented: it took me a while to work out
> what to do. Do people think we should add some documentation to this
> effect?
>
> Thanks,
> Fraser
>
> On Fri, 2021-12-10 at 19:28 +0800, shaka via llvm-dev wrote:
> > Hi all,
> >
> > I'm new for community contribution and I wonder is there a way to
> > submit patch series in a single review?
> > For example I have 2 patches: A and B. B depends on A. How can I
> > submit them together?
> > 1. The Web interface (
> >
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> > ) seems doesn't allow uploading multiple patches.
> > 2. I also tried the command line tool arc (
> >
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
> > ) by invoking `arc diff HEAD~` on each commit.
> >     But these produce 2 seperate reviews and lose dependency.
> >
> > Any advice?
> >
> > Best regards,
> > Shaka
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> >
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

llvm dev - Dec 2021 - How to submit a series of patches in a single review

[llvm-dev] How to submit a series of patches in a single review

[llvm-dev] How to submit a series of patches in a single review