Vorbis dev - Feb 2015 - Vorbis I spec errata: single entry codebooks

The following has been committed to the Vorbis I spec as of r19445:

Errata 20150226: Single entry codebooks

A ?single-entry codebook? is a codebook with one active codeword
entry.  A single-entry
codebook may be either a fully populated codebook with only one
declared entry, or a
sparse codebook with only one entry marked used. The Vorbis I spec
provides no means
to specify a codeword length of zero, and as a result, a single-entry
codebook is inherently
malformed because it is underpopulated. The original specification did
not address directly the
matter of single-entry codebooks; they were implicitly illegal as it
was not possible to write such
a codebook with a valid tree structure.

In r14811 of the libvorbis reference implementation, Xiph added an
additional check to the
codebook implementation to reject underpopulated Huffman trees. This
change led to the
discovery of single-entry books used ?in the wild? when the new,
stricter checks rejected a
number of apparently working streams.

In order to minimize breakage of deployed (if technically erroneous)
streams, r16073 of the
reference implementation explicitly special-cased single-entry
codebooks to tolerate the
single-entry case. Commit r16073 also added the following to the specification:

  "Take special care that a codebook with a single used entry is
handled properly; it consists
  of a single codework of zero bits and reading a value out of such a
codebook always returns
  the single used value and sinks zero bits. ?

The intent was to clarify the spec and codify current practice.
However, this addition is
erroneously at odds with the intent of preserving usability of
existing streams using single-
entry codebooks, disagrees with the code changes that reinstated
decoding, and does not
address how single-entry codebooks should be encoded.

As such, the above addition made in r16037 is struck from the
specification and replaced
by the following:

 "It is possible to declare a Vorbis codebook containing a single codework
en-
  try. A single-entry codebook may be either a fully populated codebook with
  [codebook_entries] set to 1, or a sparse codebook marking only one entry
  used. Note that it is not possible to also encode a [codeword_length] of zero
  for the single used codeword, as the unsigned value written to the stream is
  [codeword_length]-1. Instead, encoder implementations should indicate a
  [codeword_length] of 1 and ?write? the codeword to a stream during audio
  encoding by writing a single zero bit.

  Decoder implementations shall reject a codebook if it contains only one used
  entry and the encoded [codeword_length] of that entry is not 1. ?Reading? a
  value from single-entry codebook always returns the single used codeword value
  and sinks one bit. Decoders should tolerate that the bit read from the stream
  be ?1? instead of ?0?; both values shall return the single used codeword.

Monty
Xiph.Org

Hi Monty,

Le 26/02/2015 23:52, Monty Montgomery a ?crit :
> The following has been committed to the Vorbis I spec as of r19445:
>
[big snip]

You should also include the correction that I pointed out in the thread 
I started here :
http://lists.xiph.org/pipermail/vorbis-dev/2014-March/020378.html

In the bark(x) formula the "+ .0001x" term should be outside the
arctan
parentheses.

Cheers,
Chris

Thanks for the reminder-- yes, I will do that as well.

Monty

On Fri, Feb 27, 2015 at 10:34 AM, Chris Moore <moore at free.fr>
wrote:
> Hi Monty,
>
> Le 26/02/2015 23:52, Monty Montgomery a ?crit :
>> The following has been committed to the Vorbis I spec as of r19445:
>>
>
> [big snip]
>
> You should also include the correction that I pointed out in the thread
> I started here :
> http://lists.xiph.org/pipermail/vorbis-dev/2014-March/020378.html
>
> In the bark(x) formula the "+ .0001x" term should be outside the
arctan
> parentheses.
>
> Cheers,
> Chris
>
> _______________________________________________
> Vorbis-dev mailing list
> Vorbis-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/vorbis-dev