1) Both src/share/Makefile.am and src/share/utf8/Makefile.am have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. Why? 2) What's the purpose of charsetmap.h? It seems that it's not used anywhere.
lvqcl wrote:> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am > have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. > Why?EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am but which need to end up in the distribution tarball.> 2) What's the purpose of charsetmap.h? It seems that it's not used > anywhere.It was added in 2002, but like you said is not used anywhere. I'll remove it. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo <mle+la at mega-nerd.com> ?????(?) ? ????? ?????? Sun, 31 Jan 2016 01:47:01 +0300:>> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am >> have iconvert.h inside EXTRA_DIST, although iconvert.c includes it. >> Why? > > EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am > but which need to end up in the distribution tarball.So should it be moved from EXTRA_DIST into utf8_libutf8_la_SOURCES/libutf8_la_SOURCES where iconvert.c is mentioned?>> 2) What's the purpose of charsetmap.h? It seems that it's not used >> anywhere. > > It was added in 2002, but like you said is not used anywhere. > > I'll remove it.BTW, it's still referenced in EXTRA_DIST list in the above-mentioned two files.