lvqcl
2015-Oct-11 21:59 UTC
[flac-dev] [PATCH] stream_encoder.c: fix subframe_bps comparison
libFLAC limits the value of qlp_coeff_precision to make sure that 32-bit math is enough for decoding of 16-bit audio. subframe_bps can be equal to 17 for 16-bit input (for side channel). So the value of subframe_bps should be compared with 17, not 16 (see also http://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/stream_encoder.c;hb=02591f6b4b09e7c6e26bd2ae7225ff2810b227bb#l3431 ) -------------- next part -------------- A non-text attachment was scrubbed... Name: stream_encoder_bps.patch Type: application/octet-stream Size: 1543 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20151012/77721743/attachment.obj
Erik de Castro Lopo
2015-Oct-13 19:35 UTC
[flac-dev] [PATCH] stream_encoder.c: fix subframe_bps comparison
lvqcl wrote:> libFLAC limits the value of qlp_coeff_precision to make > sure that 32-bit math is enough for decoding of 16-bit audio. > > subframe_bps can be equal to 17 for 16-bit input (for side channel). > > So the value of subframe_bps should be compared with 17, not 16 > (see also http://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/stream_encoder.c;hb=02591f6b4b09e7c6e26bd2ae7225ff2810b227bb#l3431 )Applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Reasonably Related Threads
- [PATCH] stream_encoder : Improve selection of residual accumulator width
- [PATCH] stream_encoder : Improve selection of residual accumulator width
- Duplicate QLP coefficient restricting code
- [PATCH] stream_encoder : Improve selection of residual accumulator width
- lpc slowdown