flac dev - Feb 2012 - Regain play analysis patches

Hello Earl,  

I used your patches while they cleanly applied to the Git tree. There is one
question though, what do you think of?.

http://www.hydrogenaudio.org/forums/index.php?showtopic=84086&st=0&p=782407&#entry782407

which apparently states (if I understand correctly) that your approach is not
completely correct.

Kind regards,
Michael

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120210/73cfc280/attachment.htm

Mike,

I'm not an expert at DSP work, and I'd gladly defer to any one with any
reasonable amount of DSP experience.

I followed the link, but I'm not sure how to interpret the graph exactly. I
believe it's showing filter behaviour. The two curves look similar, but are
clearly not the same. At the 1kHz mark, the blue shows -23, and the green shows
perhaps 17.? Are they supposed to be the same ?

I believe the approach I took is reasonable based on my limited DSP knowledge
and some reading, but is probably not even close to being optimal.

That being said, I think my patch leaves us better off than before !


Earl



________________________________
From: Michael Guntsche <mike at it-loops.com>
To: flac-dev at xiph.org 
Sent: Friday, February 10, 2012 2:30:36 PM
Subject: [flac-dev] Regain play analysis patches


Hello Earl, 

I used your patches while they cleanly applied to the Git tree. There is one
question though, what do you think of?.

http://www.hydrogenaudio.org/forums/index.php?showtopic=84086&st=0&p=782407&#entry782407

which apparently states (if I understand correctly) that your approach is not
completely correct.

Kind regards,
Michael
_______________________________________________
flac-dev mailing list
flac-dev at xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Earl Chew wrote:
> That being said, I think my patch leaves us better off than before !
I agree. We will add it as it is and then tweak futher as needed.

Earl, would you be able to update your patch so that it applies
against the current git master?

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/