Hi all, Its been a while since I last compiled FLAC from source, but I just grabbed flac-1.1.3-beta2.tar.gz compiled it and then ran "make check" which resulted in this: ================== 3 of 7 tests failed ================== Is this OK? Cheers, Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo +-----------------------------------------------------------+ "When a dog, a pig, or a disbeliever touches or comes in contact with the clothes or body [of a Muslim] while he [the disbeliever] is wet, it becomes obligatory-compulsory upon him [the Muslim] to wash and clean that part which came in contact with the disbeliever." -- As taught in a British islamic school http://www.danielpipes.org/article/3560
Erik de Castro Lopo wrote:> Hi all, > > Its been a while since I last compiled FLAC from source, but I just > grabbed flac-1.1.3-beta2.tar.gz compiled it and then ran "make check" > which resulted in this:I've run the test scripts one by one and the first one to fail is test_flac.sh : Testing the metadata-handling properties of flac-to-flac encoding... case00a... Files case00a-expect.meta and out.meta differ ERROR: metadata does not match expected case00a-expect.meta The second is test_metaflac.sh : test case00: --list... Files metaflac-test-files/case00-expect.meta and metaflac-test-files/out.meta differ ERROR: metadata does not match expected metaflac-test-files/case00-expect.meta I'm still searching for the last failure. Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo +-----------------------------------------------------------+ "You can have quality software, or you can have pointer arithmetic; but you cannot have both at the same time." -- Bertrand Meyer, 1989
--- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote:> Hi all, > > Its been a while since I last compiled FLAC from source, but I just > grabbed flac-1.1.3-beta2.tar.gz compiled it and then ran "make check" > which resulted in this: > > ==================> 3 of 7 tests failed > ==================> > Is this OK?yes, this is expected on the beta, here's why: recently I switched a lot of the tests to compare metaflac output against some golden output instead of just printing results for visual inspection. it tries to filter out stuff that differs between releases, but the problem is the beta vendor string changes padding lengths in subtle ways which are not easy to work around especially when testing other things that affect the padding. so instead of regenerating all the golden files for the beta, I ran the tests with custom binary with expected vendor string to make sure they passed. for the release they will pass again. Josh ____________________________________________________________________________________ Everyone is raving about the all-new Yahoo! Mail (http://advision.webevents.yahoo.com/mailbeta/)