Janne Hyv?rinen wrote:> > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > Janne Hyv?rinen wrote: > > > >> The patch was made from the published pre2 version. It missed the MinGW > >> changes that were applied to git version. > > Patch applied. Thanks. > > > > Erik > > Unfortunately with this commit the LRN's patch from commit > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch > to bring its fixes back. Sorry I used old sources for the large patch.Applied, thanks! Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
I've been trying to get the test suite cleaned up and even with the original "untouched" test suite via flac 1.3.0pre2, I'm getting a test suite failure. *flac 1.3.0pre2* * * *configure options:* ./configure --prefix=/usr --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --enable-thorough-tests --enable-exhaustive-tests --disable-valgrind-testing --disable-static --disable-dependency-tracking --disable-debug --enable-sse --disable-3dnow --disable-altivec --disable-doxygen-docs --disable-xmms-plugin --enable-cpplibs --enable-ogg *make fullcheck:* This test fails with 'test_flac.sh': Testing --keep-foreign-metadata... round-trip test (wacky1.wav) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky2.wav) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky1.w64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky2.w64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky1.rf64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky2.rf64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK Testing the metadata-handling properties of flac-to-flac encoding... case00a... Files case00a-expect.meta and out.meta differ ERROR: metadata does not match expected case00a-expect.meta make: *** [fullcheck] Error 1 Anyone else hitting this or is just my system? On Thu, Mar 14, 2013 at 3:37 PM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote:> Janne Hyv?rinen wrote: > > > > > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > > Janne Hyv?rinen wrote: > > > > > >> The patch was made from the published pre2 version. It missed the > MinGW > > >> changes that were applied to git version. > > > Patch applied. Thanks. > > > > > > Erik > > > > Unfortunately with this commit the LRN's patch from commit > > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch > > to bring its fixes back. Sorry I used old sources for the large patch. > > Applied, thanks! > > Erik > -- > ---------------------------------------------------------------------- > Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20130318/9becc914/attachment.htm
I'd also like to note that this is happening for me with current HEAD (619b43df36b725e11e12db768d558b1930a583b6). On Mon, Mar 18, 2013 at 11:25 PM, Jaren Stangret <sirjaren at gmail.com> wrote:> I've been trying to get the test suite cleaned up and even with the > original "untouched" test suite via flac 1.3.0pre2, I'm getting a test > suite failure. > > *flac 1.3.0pre2* > * > * > *configure options:* > ./configure --prefix=/usr --build=i686-pc-linux-gnu > --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info > --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib > --disable-dependency-tracking --enable-thorough-tests > --enable-exhaustive-tests --disable-valgrind-testing --disable-static > --disable-dependency-tracking --disable-debug --enable-sse --disable-3dnow > --disable-altivec --disable-doxygen-docs --disable-xmms-plugin > --enable-cpplibs --enable-ogg > > *make fullcheck:* > This test fails with 'test_flac.sh': > > Testing --keep-foreign-metadata... > round-trip test (wacky1.wav) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky2.wav) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky1.w64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky2.w64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky1.rf64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky2.rf64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 > > Anyone else hitting this or is just my system? > > > > On Thu, Mar 14, 2013 at 3:37 PM, Erik de Castro Lopo <mle+la at mega-nerd.com > > wrote: > >> Janne Hyv?rinen wrote: >> >> > >> > On 14.3.2013 9:37, Erik de Castro Lopo wrote: >> > > Janne Hyv?rinen wrote: >> > > >> > >> The patch was made from the published pre2 version. It missed the >> MinGW >> > >> changes that were applied to git version. >> > > Patch applied. Thanks. >> > > >> > > Erik >> > >> > Unfortunately with this commit the LRN's patch from commit >> > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch >> > to bring its fixes back. Sorry I used old sources for the large patch. >> >> Applied, thanks! >> >> Erik >> -- >> ---------------------------------------------------------------------- >> Erik de Castro Lopo >> http://www.mega-nerd.com/ >> _______________________________________________ >> flac-dev mailing list >> flac-dev at xiph.org >> http://lists.xiph.org/mailman/listinfo/flac-dev >> > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20130318/b5ace699/attachment.htm
Jaren Stangret wrote:> Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 > > Anyone else hitting this or is just my system?Yes, I'm getting this too. On the list of things to fix before the release :-). Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Jaren Stangret wrote:> Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1Last night I did a git bisect on this issue and this error arose when I changed the version from "1.2.1" to "1.3.0pre1". Obvioulsy the test shouldn't have failed just because the version string changed :-). Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/