Speex dev - Jun 2005 - Bug from revision 9316: SB_ENC_STACK misdefined

Revision 9316 introduced SB_ENC_STACK and friends, but misdefines 
SB_ENC_STACK to be too small, resulting in quite noticable artifacts in 
wideband mode as well as memory corruption and a crash (sooner or later).

The patch below should return SB_ENC_STACK to be equal to what it 
replaced.

Index: sb_celp.c
==================================================================--- sb_celp.c
(revision 9379)
+++ sb_celp.c	(working copy)
@@ -49,7 +49,7 @@
  /* Default size for the encoder and decoder stack (can be changed at compile
time).
     This does not apply when using variable-size arrays or alloca. */
  #ifndef SB_ENC_STACK
-#define SB_ENC_STACK (1000*sizeof(spx_sig_t))
+#define SB_ENC_STACK (10000*sizeof(spx_sig_t))
  #endif

  #ifndef SB_DEC_STACK

Indeed, I forgot a zero. It's fixed in SVN now.

	Jean-Marc

Le lundi 06 juin 2005 ? 19:50 +0200, Thorvald Natvig a ?crit
:
> Revision 9316 introduced SB_ENC_STACK and friends, but misdefines 
> SB_ENC_STACK to be too small, resulting in quite noticable artifacts in 
> wideband mode as well as memory corruption and a crash (sooner or later).
> 
> The patch below should return SB_ENC_STACK to be equal to what it 
> replaced.
> 
> Index: sb_celp.c
> ==================================================================> ---
sb_celp.c	(revision 9379)
> +++ sb_celp.c	(working copy)
> @@ -49,7 +49,7 @@
>   /* Default size for the encoder and decoder stack (can be changed at
compile time).
>      This does not apply when using variable-size arrays or alloca. */
>   #ifndef SB_ENC_STACK
> -#define SB_ENC_STACK (1000*sizeof(spx_sig_t))
> +#define SB_ENC_STACK (10000*sizeof(spx_sig_t))
>   #endif
> 
>   #ifndef SB_DEC_STACK
> _______________________________________________
> Speex-dev mailing list
> Speex-dev@xiph.org
> http://lists.xiph.org/mailman/listinfo/speex-dev
> 
-- 
Jean-Marc Valin <Jean-Marc.Valin@USherbrooke.ca>
Universite de Sherbrooke