rsync - Jun 2016 - [Bug 11978] New: mkstemp failed: File name too long (36) when filename is under the limit

https://bugzilla.samba.org/show_bug.cgi?id=11978

            Bug ID: 11978
           Summary: mkstemp failed: File name too long (36) when filename
                    is under the limit
           Product: rsync
           Version: 3.1.1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: sambabug1.nobled at spamgourmet.com
        QA Contact: rsync-qa at samba.org

Using mkstemp adds on 7 characters to the filename, which creates a problem
when the filename is below, but close to, the limit of the filesystem.

You can see this when rsync'ing from one ecryptfs filesystem to another,
which
will fail even though both have the exact same 143-byte filename limit, if a
filename consists of more than 136 bytes.

Is there any reason the .XXXXXX in the argument to mkstemp can't *replace*
the
last 7 characters in the filename, instead of being appended to it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=11978

--- Comment #1 from Syr <sambabug1.nobled at spamgourmet.com> ---
https://git.samba.org/rsync.git/?p=rsync.git;a=blob;f=receiver.c;hb=3267d6a9ceeefad438080b17c02daa7775820803#l143

Wait, it actually adds 8 characters to it in total, there's a dot prepended
at
the beginning to.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=11978

--- Comment #2 from Syr <sambabug1.nobled at spamgourmet.com> ---
Triple post. Shouldn't it also use e.g. f_namelen from statfs() at runtime
instead of a compile-time constant?

And MAXPATHLEN doesn't even seem to reflect reality, since it's not
actually
limited to that on Linux.
https://lists.debian.org/debian-hurd/2012/01/msg00166.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=11978

Mauro Molinari <mauromol at tiscali.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mauromol at tiscali.it

--- Comment #3 from Mauro Molinari <mauromol at tiscali.it> ---
I'm also encountering problems regarding mkstemp "file name too long
error"
when rsyncing to an ecryptfs filesystem. Probably, rsync should try to handle
this in a smarter way.
A secondary problem I see is that, even if this error is given, the whole file
is transferred from source to target anyway, although not actually saved on the
target. So, if the file is huge and the bandwidth is low, this is a serious
waste.

Using rsync 3.0.9 on local side (target) and rsync 3.1.1 on remote side
(source).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.