rsync - Dec 2014 - [Bug 10989] New: "copying unsafe symlink" warning should not occur if file is not changing

https://bugzilla.samba.org/show_bug.cgi?id=10989

            Bug ID: 10989
           Summary: "copying unsafe symlink" warning should not occur
if
                    file is not changing
           Product: rsync
           Version: 3.1.1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: jim.avera at gmail.com
        QA Contact: rsync-qa at samba.org

rsync recently began issuing "copying unsafe symlink" warnings with
--verbose
even if the file in question has not changed in any way.   This pollutes the
output so you can't easily see what *has* changed.   for example, I update a
web server tree which contains many symlinks to files outside the source tree
on the source machine (and which are copied as plain files to the destination,
as expected).   Now every time I run rsync to do an update, I see a warning for
every one of those files, even though nothing has changed in any way.

So I'm requesting that rsync NOT issue that warning except when the
destination
file does not exist or is changing (i.e. content, permissions, or something) 
But NOT if nothing has changed at all.

I'll attach a demo script which shows the problem (with rsync 3.1.1 on
Ubuntu
14.10 64bit).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10989

--- Comment #1 from Jim Avera <jim.avera at gmail.com> ---
Created attachment 10497
  --> https://bugzilla.samba.org/attachment.cgi?id=10497&action=edit
Demo script

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10989

--- Comment #2 from Jim Avera <jim.avera at gmail.com> ---
A much more serious problem is that when "unsafe" symlinks are copied
pursuant
to the --copy-unsafe-links option, they are all treated as I/O ERRORS.

This prevents --delete from ever working.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10989

Jim Avera <jim.avera at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"copying unsafe symlink"    |"copying unsafe
symlink"
                   |warning treated as error,   |warnings occur if nothing
                   |prevents --delete from      |changed
                   |working                     |

--- Comment #3 from Jim Avera <jim.avera at gmail.com> ---
Sorry, please ignore comment#3 (there was so much noise from the warnings that
I didn't see that one of the 100s of links was in fact broken, and thus the
IO
Error was legitimate).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.