samba - Jan 2019 - issue with fruit:model not using avahi correctly?

hey folks,
 
I am trying to change the fruit:model value for changing the icon in the mac os
finder.
After digging a little bit in the source code I saw that
"source3/smbd/avahi_register.c" does not contain a line where info
like
<service>
<type>_device-info._tcp</type>
<port>0</port>
<txt-record>model=RackMac</txt-record>
is added to avahi.
In "source3/modules/vfs_fruit.c" I see that the paramater fruit:model
is processed, but it does not seem to be used by avahi_register nor does it seem
to be propagted.
 
These lines should be responsible for making smb show up correctly in the Finder
sidebar with a correct icon.
 
Is this a bug/not available feature or did I misunderstand something?
 
I am not thinking my config os corrupted since my time machine share is
propageted correctly (based on the avahi infos).
 
Some link that helped me:
https://jonathanmumm.com/tech-it/mdns-bonjour-bible-common-service-strings-for-various-vendors/
https://simonwheatley.co.uk/2008/04/avahi-finder-icons/
 
Thanks for your help.

Hi Rouven,

you're correct, our avahi callback did not use fruit:model at all. Can
you try the attached patch? It should make it work.

Thanks,
Guenther

On 15/01/2019 09:27, Rouven WEILER via samba wrote:
> hey folks,
>  
> I am trying to change the fruit:model value for changing the icon in the
mac os finder.
> After digging a little bit in the source code I saw that
"source3/smbd/avahi_register.c" does not contain a line where info
like
> <service>
> <type>_device-info._tcp</type>
> <port>0</port>
> <txt-record>model=RackMac</txt-record>
> is added to avahi.
> In "source3/modules/vfs_fruit.c" I see that the paramater
fruit:model is processed, but it does not seem to be used by avahi_register nor
does it seem to be propagted.
>  
> These lines should be responsible for making smb show up correctly in the
Finder sidebar with a correct icon.
>  
> Is this a bug/not available feature or did I misunderstand something?
>  
> I am not thinking my config os corrupted since my time machine share is
propageted correctly (based on the avahi infos).
>  
> Some link that helped me:
>
https://jonathanmumm.com/tech-it/mdns-bonjour-bible-common-service-strings-for-various-vendors/
> https://simonwheatley.co.uk/2008/04/avahi-finder-icons/
>  
> Thanks for your help.
> 

-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org
-------------- next part --------------