Miguel Medalha
2016-Mar-16 20:33 UTC
[Samba] [Announce] Samba 4.4.0rc5 Available for Download
> When building Samba 4.4.0rc and then doing an install to /usr/local/samba, a directory "libexec" is being created which then contains a "samba" directory with a single "smbspool_krb5_wrapper" file inside (/usr/local/samba/libexec/samba/ smbspool_krb5_wrapper). This is not very clean, is it? > > Since all the files are already inside /usr/local/samba, why repeat "samba" again inside the tree? Is it possible to clean this before the final release of Samba 4.4.0? > > This doesn't happen with version 4.3.6. The same file is placed in "/usr/local/samba/bin/smbspool_krb5_wrapper".Some additional information: if I configure the build with "--libexecdir=/usr/local/samba/bin" the file goes into "usr/local/samba/bin/samba/smbspool_krb5_wrapper" which also contains an unnecessary repetition. That additional "samba" directory seems to be hard coded somewhere.
Andrew Bartlett
2016-Mar-19 01:42 UTC
[Samba] [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
On Wed, 2016-03-16 at 20:33 +0000, Miguel Medalha wrote:> > When building Samba 4.4.0rc and then doing an install to > > /usr/local/samba, a directory "libexec" is being created which then > > contains a "samba" directory with a single "smbspool_krb5_wrapper" > > file inside (/usr/local/samba/libexec/samba/ > > smbspool_krb5_wrapper). This is not very clean, is it? > > > > Since all the files are already inside /usr/local/samba, why repeat > > "samba" again inside the tree? Is it possible to clean this before > > the final release of Samba 4.4.0? > > > > This doesn't happen with version 4.3.6. The same file is placed in > > "/usr/local/samba/bin/smbspool_krb5_wrapper". > > Some additional information: if I configure the build with > "--libexecdir=/usr/local/samba/bin" the file goes into > "usr/local/samba/bin/samba/smbspool_krb5_wrapper" which also contains > an > unnecessary repetition. That additional "samba" directory seems to be > hard coded somewhere.Try this patch. Andreas: Can you comment on this and let me know if this is OK for what you were looking for? For some reason smbspool_krb5_wrapper doesn't build on my system, so I cna't fully test it, so consider this a WIP. Amitay/Martin: Please comment on the CTDB changes. Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-build-set-LIBEXECDIR-to-include-a-trailing-samba-in-.patch Type: text/x-patch Size: 3070 bytes Desc: not available URL: <http://lists.samba.org/pipermail/samba/attachments/20160319/bd8570e3/0001-build-set-LIBEXECDIR-to-include-a-trailing-samba-in-.bin>
Andreas Schneider
2016-Mar-19 11:41 UTC
[Samba] [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
On Saturday 19 March 2016 14:42:32 Andrew Bartlett wrote:> On Wed, 2016-03-16 at 20:33 +0000, Miguel Medalha wrote: > > > When building Samba 4.4.0rc and then doing an install to > > > /usr/local/samba, a directory "libexec" is being created which then > > > contains a "samba" directory with a single "smbspool_krb5_wrapper" > > > file inside (/usr/local/samba/libexec/samba/ > > > smbspool_krb5_wrapper). This is not very clean, is it? > > > > > > Since all the files are already inside /usr/local/samba, why repeat > > > "samba" again inside the tree? Is it possible to clean this before > > > the final release of Samba 4.4.0? > > > > > > This doesn't happen with version 4.3.6. The same file is placed in > > > "/usr/local/samba/bin/smbspool_krb5_wrapper". > > > > Some additional information: if I configure the build with > > "--libexecdir=/usr/local/samba/bin" the file goes into > > "usr/local/samba/bin/samba/smbspool_krb5_wrapper" which also contains > > an > > unnecessary repetition. That additional "samba" directory seems to be > > hard coded somewhere. > > Try this patch. > > Andreas: Can you comment on this and let me know if this is OK for > what you were looking for?It looks fine for me. Martin should look at the ctdb changes. If the binaries move, some scripts need to be updated too iirc. So Martin needs to look into this!> For some reason smbspool_krb5_wrapper doesn't build on my system, so I > cna't fully test it, so consider this a WIP.What error do you get? Cheers, -- andreas -- Andreas Schneider GPG-ID: CC014E3D Samba Team asn at samba.org www.samba.org
Miguel Medalha
2016-Mar-20 18:57 UTC
[Samba] [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
>>> When building Samba 4.4.0rc and then doing an install to >>> /usr/local/samba, a directory "libexec" is being created which then >>> contains a "samba" directory with a single "smbspool_krb5_wrapper" >>> file inside (/usr/local/samba/libexec/samba/ >>> smbspool_krb5_wrapper). This is not very clean, is it? >>> >>> Since all the files are already inside /usr/local/samba, why repeat >>> "samba" again inside the tree? Is it possible to clean this before >>> the final release of Samba 4.4.0? >>> >>> This doesn't happen with version 4.3.6. The same file is placed in >>> "/usr/local/samba/bin/smbspool_krb5_wrapper". >> Some additional information: if I configure the build with >> "--libexecdir=/usr/local/samba/bin" the file goes into >> "usr/local/samba/bin/samba/smbspool_krb5_wrapper" which also contains >> an >> unnecessary repetition. That additional "samba" directory seems to be >> hard coded somewhere. > Try this patch.Thank you for writing the patch. Maybe I am being picky or (most probably) ignoring some valid motive, but why does "smbspool_krb5_wrapper" need a "libexec" directory just for itself? Was there something wrong with keeping this file in "/usr/local/samba/bin" as it happened with samba 4.3.6? Why complicate the tree?
Reasonably Related Threads
- [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
- [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
- [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
- [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4
- [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4