Chris Tetreault via llvm-dev
2020-Oct-29 20:47 UTC
[llvm-dev] [RFC] FileCheck: (dis)allowing unused prefixes
It seems like nothing is checking GISEL-NOOPT-NEXT and GISEL-OPT-NEXT. Perhaps this is the issue? -----Original Message----- From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Paul C. Anagnostopoulos via llvm-dev Sent: Thursday, October 29, 2020 1:30 PM To: llvm-dev at lists.llvm.org Subject: [EXT] Re: [llvm-dev] [RFC] FileCheck: (dis)allowing unused prefixes I'm not very familiar with FileCheck yet so this may be a silly question. I noticed that TableGen/GlobalISelEmitter-immAllZeroOne.td is on the list, so I checked it out. If I understand correctly, I expect GISEL-OPT and/or GISEL-NOOPT to be misspelled somewhere, but they are not. Can someone sort me out? // RUN: llvm-tblgen -gen-global-isel -warn-on-skipped-patterns -optimize-match-table=false -I %p/../../include -I %p/Common %s -o - | FileCheck -check-prefixes=GISEL-NOOPT,GISEL %s // RUN: llvm-tblgen -gen-global-isel -warn-on-skipped-patterns -optimize-match-table=true -I %p/../../include -I %p/Common %s -o - | FileCheck -check-prefixes=GISEL-OPT,GISEL %s _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Mircea Trofin via llvm-dev
2020-Oct-29 21:13 UTC
[llvm-dev] [RFC] FileCheck: (dis)allowing unused prefixes
Actually, it's the 'GISEL:' that's missing. Here's what you get after the patch is applied, if you add --allow-unused-prefixes=true to the FileCheck call in both RUN lines: $ build-all-Release/bin/llvm-lit llvm/test/TableGen/GlobalISelEmitter-immAllZeroOne.td -a -- Testing: 1 tests, 1 workers -- FAIL: LLVM :: TableGen/GlobalISelEmitter-immAllZeroOne.td (1 of 1) ******************** TEST 'LLVM :: TableGen/GlobalISelEmitter-immAllZeroOne.td' FAILED ******************** Script: -- : 'RUN: at line 1'; /other/llvm-project/build-all-Release/bin/llvm-tblgen -gen-global-isel -warn-on-skipped-patterns -optimize-match-table=false -I /other/llvm-project/llvm/test/TableGen/../../include -I /other/llvm-project/llvm/test/TableGen/Common /other/llvm-project/llvm/test/TableGen/GlobalISelEmitter-immAllZeroOne.td -o - | /other/llvm-project/build-all-Release/bin/FileCheck -check-prefixes=GISEL-NOOPT,GISEL /other/llvm-project/llvm/test/TableGen/GlobalISelEmitter-immAllZeroOne.td --allow-unused-prefixes=false : 'RUN: at line 2'; /other/llvm-project/build-all-Release/bin/llvm-tblgen -gen-global-isel -warn-on-skipped-patterns -optimize-match-table=true -I /other/llvm-project/llvm/test/TableGen/../../include -I /other/llvm-project/llvm/test/TableGen/Common /other/llvm-project/llvm/test/TableGen/GlobalISelEmitter-immAllZeroOne.td -o - | /other/llvm-project/build-all-Release/bin/FileCheck -check-prefixes=GISEL-OPT,GISEL /other/llvm-project/llvm/test/TableGen/GlobalISelEmitter-immAllZeroOne.td --allow-unused-prefixes=false -- Exit Code: 2 Command Output (stderr): -- error: no check strings found with prefix 'GISEL:' -- ******************** ******************** Failed Tests (1): LLVM :: TableGen/GlobalISelEmitter-immAllZeroOne.td Testing Time: 0.17s Failed: 1 On Thu, Oct 29, 2020 at 1:48 PM Chris Tetreault via llvm-dev < llvm-dev at lists.llvm.org> wrote:> It seems like nothing is checking GISEL-NOOPT-NEXT and GISEL-OPT-NEXT. > Perhaps this is the issue? > > -----Original Message----- > From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Paul C. > Anagnostopoulos via llvm-dev > Sent: Thursday, October 29, 2020 1:30 PM > To: llvm-dev at lists.llvm.org > Subject: [EXT] Re: [llvm-dev] [RFC] FileCheck: (dis)allowing unused > prefixes > > I'm not very familiar with FileCheck yet so this may be a silly question. > I noticed that TableGen/GlobalISelEmitter-immAllZeroOne.td is on the list, > so I checked it out. If I understand correctly, I expect GISEL-OPT and/or > GISEL-NOOPT to be misspelled somewhere, but they are not. Can someone sort > me out? > > > // RUN: llvm-tblgen -gen-global-isel -warn-on-skipped-patterns > -optimize-match-table=false -I %p/../../include -I %p/Common %s -o - | > FileCheck -check-prefixes=GISEL-NOOPT,GISEL %s // RUN: llvm-tblgen > -gen-global-isel -warn-on-skipped-patterns -optimize-match-table=true -I > %p/../../include -I %p/Common %s -o - | FileCheck > -check-prefixes=GISEL-OPT,GISEL %s > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20201029/fe49f08a/attachment.html>