Libguestfs - Apr 2019 - [PATCH] v2v: update documentation on nbdkit (RHBZ#1605242)

nbdkit >= 1.6 ships a VDDK plugin always built, so recommend that
version instead of recommending to build nbdkit from sources.
---
 v2v/virt-v2v-input-vmware.pod | 28 ++--------------------------
 1 file changed, 2 insertions(+), 26 deletions(-)

diff --git a/v2v/virt-v2v-input-vmware.pod b/v2v/virt-v2v-input-vmware.pod
index 2b6dbaeec..b3ebda182 100644
--- a/v2v/virt-v2v-input-vmware.pod
+++ b/v2v/virt-v2v-input-vmware.pod
@@ -197,32 +197,8 @@ library is permitted by the license.
 
 =item 2.
 
-You must also compile nbdkit, enabling the VDDK plugin.  nbdkit E<ge>
-1.1.25 is recommended, but it is usually best to compile from the git
-tree.
-
-=over 4
-
-=item *
-
-L<https://github.com/libguestfs/nbdkit>
-
-=item *
-
-L<https://github.com/libguestfs/nbdkit/tree/master/plugins/vddk>
-
-=back
-
-Compile nbdkit as described in the sources (see link above).
-
-You do B<not> need to run C<make install> because you can run
nbdkit
-from its source directory.  The source directory has a shell script
-called F<nbdkit> which runs the locally built copy of nbdkit and its
-plugins.  So set C<$PATH> to point to the nbdkit top build directory
-(that is, the directory containing the shell script called F<nbdkit>),
-eg:
-
- export PATH=/path/to/nbdkit-1.1.x:$PATH
+nbdkit E<ge> 1.6 is recommended, as it ships with the VDDK plugin
+enabled unconditionally.
 
 =item 3.
 
-- 
2.20.1

On Fri, Apr 12, 2019 at 04:22:18PM +0200, Pino Toscano
wrote:
> nbdkit >= 1.6 ships a VDDK plugin always built, so recommend that
> version instead of recommending to build nbdkit from sources.
> ---
>  v2v/virt-v2v-input-vmware.pod | 28 ++--------------------------
>  1 file changed, 2 insertions(+), 26 deletions(-)
> 
> diff --git a/v2v/virt-v2v-input-vmware.pod b/v2v/virt-v2v-input-vmware.pod
> index 2b6dbaeec..b3ebda182 100644
> --- a/v2v/virt-v2v-input-vmware.pod
> +++ b/v2v/virt-v2v-input-vmware.pod
> @@ -197,32 +197,8 @@ library is permitted by the license.
>  
>  =item 2.
>  
> -You must also compile nbdkit, enabling the VDDK plugin.  nbdkit
E<ge>
> -1.1.25 is recommended, but it is usually best to compile from the git
> -tree.
> -
> -=over 4
> -
> -=item *
> -
> -L<https://github.com/libguestfs/nbdkit>
> -
> -=item *
> -
> -L<https://github.com/libguestfs/nbdkit/tree/master/plugins/vddk>
> -
> -=back
> -
> -Compile nbdkit as described in the sources (see link above).
> -
> -You do B<not> need to run C<make install> because you can run
nbdkit
> -from its source directory.  The source directory has a shell script
> -called F<nbdkit> which runs the locally built copy of nbdkit and its
> -plugins.  So set C<$PATH> to point to the nbdkit top build directory
> -(that is, the directory containing the shell script called
F<nbdkit>),
> -eg:
> -
> - export PATH=/path/to/nbdkit-1.1.x:$PATH
> +nbdkit E<ge> 1.6 is recommended, as it ships with the VDDK plugin
> +enabled unconditionally.
ACK

This min dep move to nbdkit 1.12 if the other patch series I posted is
approved, but in any case there's no need to ever compile the VDDK
plugin separately these days.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW