Pino Toscano
2018-May-09 16:08 UTC
[Libguestfs] [PATCH] v2v: update results of test-v2v-i-ova-snapshots for non-json
When using non-JSON disk notation, the disk will be the snapshot #2. Fixes commit e5946165c8ea78e0e91c4cfdb5e793526cd638e1. --- v2v/test-v2v-i-ova-snapshots.expected | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/test-v2v-i-ova-snapshots.expected b/v2v/test-v2v-i-ova-snapshots.expected index 97bce58ad..a64843b35 100644 --- a/v2v/test-v2v-i-ova-snapshots.expected +++ b/v2v/test-v2v-i-ova-snapshots.expected @@ -13,7 +13,7 @@ hypervisor type: vmware video: sound: disks: - disk1.vmdk (vmdk) [scsi] + disk1.vmdk.000000002 (vmdk) [scsi] removable media: CD-ROM [ide] in slot 0 NICs: -- 2.14.3
Richard W.M. Jones
2018-May-11 07:21 UTC
Re: [Libguestfs] [PATCH] v2v: update results of test-v2v-i-ova-snapshots for non-json
On Wed, May 09, 2018 at 06:08:56PM +0200, Pino Toscano wrote:> When using non-JSON disk notation, the disk will be the snapshot #2. > > Fixes commit e5946165c8ea78e0e91c4cfdb5e793526cd638e1. > --- > v2v/test-v2v-i-ova-snapshots.expected | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/test-v2v-i-ova-snapshots.expected b/v2v/test-v2v-i-ova-snapshots.expected > index 97bce58ad..a64843b35 100644 > --- a/v2v/test-v2v-i-ova-snapshots.expected > +++ b/v2v/test-v2v-i-ova-snapshots.expected > @@ -13,7 +13,7 @@ hypervisor type: vmware > video: > sound: > disks: > - disk1.vmdk (vmdk) [scsi] > + disk1.vmdk.000000002 (vmdk) [scsi] > removable media: > CD-ROM [ide] in slot 0 > NICs:ACK Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
Possibly Parallel Threads
- Re: [PATCH 1/1] v2v: ova: fix generated JSON for libvirt support
- Re: [PATCH v2 5/5] v2v: update tests to match changes in OVA import
- [PATCH] v2v: tests: avoid '..' in member names for tar
- [PATCH v5 0/2] Improve OVA manifest parsing
- [PATCH] v2v: handle subfolders in ova files