Linux Virtualization - Sep 2017 - [PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default

There is no recent user space application available anymore which still
supports this old virtio transport, so let's disable this by default.

Signed-off-by: Thomas Huth <thuth at redhat.com>
---
 arch/s390/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 48af970..923bf04 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -930,7 +930,7 @@ config S390_GUEST
 	  the KVM hypervisor.
 
 config S390_GUEST_OLD_TRANSPORT
-	def_bool y
+	def_bool n
 	prompt "Guest support for old s390 virtio transport (DEPRECATED)"
 	depends on S390_GUEST
 	help
-- 
1.8.3.1

On 09/25/2017 04:45 PM, Thomas Huth wrote:
> There is no recent user space application available anymore which still
> supports this old virtio transport, so let's disable this by default.
> 
> Signed-off-by: Thomas Huth <thuth at redhat.com>
I don't have any objections, but there may be something I'm not aware
of.
Let's see what Connie says. From my side it's ack.

Via whom is this supposed to go in? Looking at the MAINTAINERS, I would
say Martin or Heiko but I don't see them among the recipients.

Regards,
Halil
> ---
>  arch/s390/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 48af970..923bf04 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -930,7 +930,7 @@ config S390_GUEST
>  	  the KVM hypervisor.
> 
>  config S390_GUEST_OLD_TRANSPORT
> -	def_bool y
> +	def_bool n
>  	prompt "Guest support for old s390 virtio transport
(DEPRECATED)"
>  	depends on S390_GUEST
>  	help
>

On 09/25/2017 07:54 PM, Halil Pasic wrote:
> 
> 
> On 09/25/2017 04:45 PM, Thomas Huth wrote:
>> There is no recent user space application available anymore which still
>> supports this old virtio transport, so let's disable this by
default.
>>
>> Signed-off-by: Thomas Huth <thuth at redhat.com>
> 
> I don't have any objections, but there may be something I'm not
aware of.
> Let's see what Connie says. From my side it's ack.
> 
> Via whom is this supposed to go in? Looking at the MAINTAINERS, I would
> say Martin or Heiko but I don't see them among the recipients.
FWIW as the original author of that transport
Acked-by: Christian Borntraeger <borntraeger at de.ibm.com>

I can pick this up for Martins/Heikos tree if you want.
> 
> Regards,
> Halil
> 
>> ---
>>  arch/s390/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
>> index 48af970..923bf04 100644
>> --- a/arch/s390/Kconfig
>> +++ b/arch/s390/Kconfig
>> @@ -930,7 +930,7 @@ config S390_GUEST
>>  	  the KVM hypervisor.
>>
>>  config S390_GUEST_OLD_TRANSPORT
>> -	def_bool y
>> +	def_bool n
>>  	prompt "Guest support for old s390 virtio transport
(DEPRECATED)"
>>  	depends on S390_GUEST
>>  	help
>>

On 09/25/2017 04:45 PM, Thomas Huth wrote:
> There is no recent user space application available anymore which still
> supports this old virtio transport, so let's disable this by default.
> 
> Signed-off-by: Thomas Huth <thuth at redhat.com>
thanks applied.
> ---
>  arch/s390/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 48af970..923bf04 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -930,7 +930,7 @@ config S390_GUEST
>  	  the KVM hypervisor.
> 
>  config S390_GUEST_OLD_TRANSPORT
> -	def_bool y
> +	def_bool n
>  	prompt "Guest support for old s390 virtio transport
(DEPRECATED)"
>  	depends on S390_GUEST
>  	help
>

On Mon, 25 Sep 2017 16:45:29 +0200
Thomas Huth <thuth at redhat.com> wrote:
> There is no recent user space application available anymore which still
> supports this old virtio transport, so let's disable this by default.
> 
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
>  arch/s390/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 48af970..923bf04 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -930,7 +930,7 @@ config S390_GUEST
>  	  the KVM hypervisor.
>  
>  config S390_GUEST_OLD_TRANSPORT
> -	def_bool y
> +	def_bool n
>  	prompt "Guest support for old s390 virtio transport
(DEPRECATED)"
>  	depends on S390_GUEST
>  	help
Acked-by: Cornelia Huck <cohuck at redhat.com>