search for: config_s390_guest_old_transport

On 09/25/2017 04:45 PM, Thomas Huth wrote: > There is no recent user space application available anymore which still > supports this old virtio transport, so let's disable this by default. > > Signed-off-by: Thomas Huth <thuth at redhat.com> I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side

On 09/25/2017 04:45 PM, Thomas Huth wrote: > There is no recent user space application available anymore which still > supports this old virtio transport, so let's disable this by default. > > Signed-off-by: Thomas Huth <thuth at redhat.com> thanks applied. > --- > arch/s390/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: > > On 09/25/2017 07:54 PM, Halil Pasic wrote: > > > > > > On 09/25/2017 04:45 PM, Thomas Huth wrote: > >> There is no recent user space application available anymore which still > >> supports this old virtio transport, so let's disable this by default. > >> >

On Tue, Sep 26, 2017 at 12:57:26PM +0200, Thomas Huth wrote: > On 26.09.2017 12:47, Heiko Carstens wrote: > > So it's going to be removed with the next merge window. > > Where is the patch? ;) > > Hmm, so far the code was always enabled by default, so in the unlikely > case that somebody is still using it, they might not have noticed that > this is marked as

On Tue, Sep 26, 2017 at 12:41:41PM +0200, Christian Borntraeger wrote: > > > On 09/26/2017 12:40 PM, Heiko Carstens wrote: > > On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: > >> > >> On 09/25/2017 07:54 PM, Halil Pasic wrote: > >>> > >>> > >>> On 09/25/2017 04:45 PM, Thomas Huth wrote: >

On 26.09.2017 12:47, Heiko Carstens wrote: > On Tue, Sep 26, 2017 at 12:41:41PM +0200, Christian Borntraeger wrote: >> >> >> On 09/26/2017 12:40 PM, Heiko Carstens wrote: >>> On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: >>>> >>>> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>>>> >>>>>

On 26.09.2017 12:47, Heiko Carstens wrote: > On Tue, Sep 26, 2017 at 12:41:41PM +0200, Christian Borntraeger wrote: >> >> >> On 09/26/2017 12:40 PM, Heiko Carstens wrote: >>> On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: >>>> >>>> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>>>> >>>>>

There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default. Signed-off-by: Thomas Huth <thuth at redhat.com> --- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 48af970..923bf04 100644 --- a/arch/s390/Kconfig +++

There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default. Signed-off-by: Thomas Huth <thuth at redhat.com> --- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 48af970..923bf04 100644 --- a/arch/s390/Kconfig +++

On 09/25/2017 07:54 PM, Halil Pasic wrote: > > > On 09/25/2017 04:45 PM, Thomas Huth wrote: >> There is no recent user space application available anymore which still >> supports this old virtio transport, so let's disable this by default. >> >> Signed-off-by: Thomas Huth <thuth at redhat.com> > > I don't have any objections, but there may be

On 09/25/2017 07:54 PM, Halil Pasic wrote: > > > On 09/25/2017 04:45 PM, Thomas Huth wrote: >> There is no recent user space application available anymore which still >> supports this old virtio transport, so let's disable this by default. >> >> Signed-off-by: Thomas Huth <thuth at redhat.com> > > I don't have any objections, but there may be

On 09/26/2017 12:40 PM, Heiko Carstens wrote: > On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: >> >> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>> >>> >>> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>>> There is no recent user space application available anymore which still >>>> supports this old virtio

On 09/26/2017 12:40 PM, Heiko Carstens wrote: > On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: >> >> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>> >>> >>> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>>> There is no recent user space application available anymore which still >>>> supports this old virtio

...+6,8 @@ > ?# it under the terms of the GNU General Public License (version 2 > only) > ?# as published by the Free Software Foundation. > ? > +CFLAGS_virtio_ccw.o += -D__CHECK_ENDIAN__ > +CFLAGS_kvm_virtio.o += -D__CHECK_ENDIAN__ > ?s390-virtio-objs := virtio_ccw.o > ?ifdef CONFIG_S390_GUEST_OLD_TRANSPORT > ?s390-virtio-objs += kvm_virtio.o Here you could use ccflags-y += -D__CHECK_ENDIAN__ for example, or even subdir-ccflags-y += -D__CHECK_ENDIAN__ (in case any subdirs ever get added here) > --- a/drivers/vhost/Makefile > +++ b/drivers/vhost/Makefile > @@ -1,3 +1,4 @@ > +ccflag...

.../s390/virtio/Makefile >> index df40692..d9942e0 100644 >> --- a/drivers/s390/virtio/Makefile >> +++ b/drivers/s390/virtio/Makefile >> @@ -7,7 +7,4 @@ >> # as published by the Free Software Foundation. >> >> s390-virtio-objs := virtio_ccw.o >> -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT >> -s390-virtio-objs += kvm_virtio.o >> -endif >> obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) > > Would you mind to simplify the Makefile to just the single line > > obj-$(CONFIG_S390_GUEST) += virtio_ccw.o > > while you are touching it anyway? Sure ......

...+6,8 @@ > ?# it under the terms of the GNU General Public License (version 2 > only) > ?# as published by the Free Software Foundation. > ? > +CFLAGS_virtio_ccw.o += -D__CHECK_ENDIAN__ > +CFLAGS_kvm_virtio.o += -D__CHECK_ENDIAN__ > ?s390-virtio-objs := virtio_ccw.o > ?ifdef CONFIG_S390_GUEST_OLD_TRANSPORT > ?s390-virtio-objs += kvm_virtio.o Here you could use ccflags-y += -D__CHECK_ENDIAN__ for example, or even subdir-ccflags-y += -D__CHECK_ENDIAN__ (in case any subdirs ever get added here) > --- a/drivers/vhost/Makefile > +++ b/drivers/vhost/Makefile > @@ -1,3 +1,4 @@ > +ccflag...

.../s390/virtio/Makefile >> index df40692..d9942e0 100644 >> --- a/drivers/s390/virtio/Makefile >> +++ b/drivers/s390/virtio/Makefile >> @@ -7,7 +7,4 @@ >> # as published by the Free Software Foundation. >> >> s390-virtio-objs := virtio_ccw.o >> -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT >> -s390-virtio-objs += kvm_virtio.o >> -endif >> obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) > > Would you mind to simplify the Makefile to just the single line > > obj-$(CONFIG_S390_GUEST) += virtio_ccw.o > > while you are touching it anyway? Sure ......

...d this. - endmenu diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile index df40692..d9942e0 100644 --- a/drivers/s390/virtio/Makefile +++ b/drivers/s390/virtio/Makefile @@ -7,7 +7,4 @@ # as published by the Free Software Foundation. s390-virtio-objs := virtio_ccw.o -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT -s390-virtio-objs += kvm_virtio.o -endif obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) diff --git a/drivers/s390/virtio/kvm_virtio.c b/drivers/s390/virtio/kvm_virtio.c deleted file mode 100644 index a99d09a..0000000 --- a/drivers/s390/virtio/kvm_virtio.c +++ /dev/null @@ -1,515 +0,0 @@ -/* - * v...

...d this. - endmenu diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile index df40692..d9942e0 100644 --- a/drivers/s390/virtio/Makefile +++ b/drivers/s390/virtio/Makefile @@ -7,7 +7,4 @@ # as published by the Free Software Foundation. s390-virtio-objs := virtio_ccw.o -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT -s390-virtio-objs += kvm_virtio.o -endif obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) diff --git a/drivers/s390/virtio/kvm_virtio.c b/drivers/s390/virtio/kvm_virtio.c deleted file mode 100644 index a99d09a..0000000 --- a/drivers/s390/virtio/kvm_virtio.c +++ /dev/null @@ -1,515 +0,0 @@ -/* - * v...

.../s390/virtio/Makefile b/drivers/s390/virtio/Makefile > index df40692..d9942e0 100644 > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -7,7 +7,4 @@ > # as published by the Free Software Foundation. > > s390-virtio-objs := virtio_ccw.o > -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT > -s390-virtio-objs += kvm_virtio.o > -endif > obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) Would you mind to simplify the Makefile to just the single line obj-$(CONFIG_S390_GUEST) += virtio_ccw.o while you are touching it anyway?