Ben Dooks
2019-Oct-09  11:58 UTC
[Nouveau] [PATCH] drm/nouveau/core/client: make nvkm_uclient_sclass static
The nvkm_uclient_sclass object is not used outside the file
it is defined in, so make it static to avoid the following
sparse warning:
drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol
'nvkm_uclient_sclass' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
---
Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: David Airlie <airlied at linux.ie>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: dri-devel at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
---
 drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/client.c
b/drivers/gpu/drm/nouveau/nvkm/core/client.c
index ac671202919e..0c8c55c73b12 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/client.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/client.c
@@ -60,7 +60,7 @@ nvkm_uclient_new(const struct nvkm_oclass *oclass, void *argv,
u32 argc,
 	return 0;
 }
 
-const struct nvkm_sclass
+static const struct nvkm_sclass
 nvkm_uclient_sclass = {
 	.oclass = NVIF_CLASS_CLIENT,
 	.minver = 0,
-- 
2.23.0
Seemingly Similar Threads
- [PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static
 - [PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static
 - [PATCH 3/5] drm/nouveau/fifo/gv100: make gv100_fifo_runlist static
 - [PATCH 5/5] drm/nouveau/disp/gv100: make gv100_disp_wimm static
 - [PATCH] drm/nouveau/falcon: make unexported objects static
 
