David Howells
2016-Dec-01 12:29 UTC
[Nouveau] [PATCH 02/39] Annotate hardware config module parameters in arch/x86/mm/
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in arch/x86/mm/. Suggested-by: One Thousand Gnomes <gnomes at lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowells at redhat.com> cc: Steven Rostedt <rostedt at goodmis.org> cc: Ingo Molnar <mingo at kernel.org> cc: Thomas Gleixner <tglx at linutronix.de> cc: "H. Peter Anvin" <hpa at zytor.com> cc: x86 at kernel.org cc: linux-kernel at vger.kernel.org cc: nouveau at lists.freedesktop.org --- arch/x86/mm/testmmiotrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/testmmiotrace.c b/arch/x86/mm/testmmiotrace.c index 38868adf07ea..f6ae6830b341 100644 --- a/arch/x86/mm/testmmiotrace.c +++ b/arch/x86/mm/testmmiotrace.c @@ -9,7 +9,7 @@ #include <linux/mmiotrace.h> static unsigned long mmio_address; -module_param(mmio_address, ulong, 0); +module_param_hw(mmio_address, ulong, iomem, 0); MODULE_PARM_DESC(mmio_address, " Start address of the mapping of 16 kB " "(or 8 MB if read_far is non-zero).");
Reasonably Related Threads
- [PATCH 02/38] Annotate hardware config module parameters in arch/x86/mm/
- [PATCHv2] kmmio/mmiotrace: fix double free of kmmio_fault_pages
- [GIT PULL] x86/mm for 2.6.36
- [PATCH 09/35] x86: Convert remaining uses of pr_warning to pr_warn
- [PATCH] kmmio/mmiotrace: fix double free of kmmio_fault_pages