2015-06-04 13:04 GMT+02:00 Bastien Nocera <hadess at hadess.net>:> On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote: > > > > > > 2015-05-29 14:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > > On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote: > > > > Hi Richard and the list, > > > > > > > > you'll find attached a patch for 95-upower-hid.rules, which adds: > > > > - the "usbmisc" filtering, as added in your repo, > > > > - more comments, including one that points at your UPower repo, > > > > - 3 new manufacturers (Minibox, iDowell and Powerware) > > > > - a bunch of new devices (7 HP, 1 APC, 1 TrippLite, 2 PowerCOM > > > and 2 > > > > Liebert) > > > > > > Could you please split those changes into 3 separate patches? > > > > since you already have the "usbmisc", I can possibly check to split > > in 2 commits (1 for the comments, and 1 for the content update). > > would that suits you that way? > > Sure. > > > > It would also be useful to include a full URL to the NUT Perl > > > script > > > (to a git repository perhaps), so people don't need to check out > > > the > > > full repo to update it. > > > > > as per Charles comments, beside from the perl script, you need all > > the drivers/*hid.c files to extract the USB info. > > the added comment was just to shed light on the fact that it's an > > automated data extraction. > > I can reword to make it more clear if you want. > > Just changing the path to project page URL + the path would be fine > (that means that somebody unfamiliar with NUT's upstream can actually > find the scripts to update this file). >Prior to pushing the changes in NUT and to generate the patches for UPower, does the below header suit you: # Uninterruptible Power Supplies with USB HID interfaces # # http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules # # This file was automatically generated by NUT: # https://github.com/networkupstools/nut/ # # To keep up to date, monitor upstream NUT # https://github.com/networkupstools/nut/commits/master/scripts/upower/95-upower-hid.rules # or checkout the NUT repository and call 'tools/nut-usbinfo.pl' Or do you see any other better wording? thanks and cheers, Arno -- Eaton Data Center Automation - Opensource Leader NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.fr -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/7d08cb76/attachment-0001.html>
On Mon, 2015-06-08 at 09:45 +0200, Arnaud Quette wrote:> > > 2015-06-04 13:04 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote: > > > > > > > > > 2015-05-29 14:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > > > On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote: > > > > > Hi Richard and the list, > > > > > > > > > > you'll find attached a patch for 95-upower-hid.rules, which > > adds: > > > > > - the "usbmisc" filtering, as added in your repo, > > > > > - more comments, including one that points at your UPower > > repo, > > > > > - 3 new manufacturers (Minibox, iDowell and Powerware) > > > > > - a bunch of new devices (7 HP, 1 APC, 1 TrippLite, 2 > > PowerCOM > > > > and 2 > > > > > Liebert) > > > > > > > > Could you please split those changes into 3 separate patches? > > > > > > since you already have the "usbmisc", I can possibly check to > > split > > > in 2 commits (1 for the comments, and 1 for the content update). > > > would that suits you that way? > > > > Sure. > > > > > > It would also be useful to include a full URL to the NUT Perl > > > > script > > > > (to a git repository perhaps), so people don't need to check > > out > > > > the > > > > full repo to update it. > > > > > > > as per Charles comments, beside from the perl script, you need > > all > > > the drivers/*hid.c files to extract the USB info. > > > the added comment was just to shed light on the fact that it's an > > > automated data extraction. > > > I can reword to make it more clear if you want. > > > > Just changing the path to project page URL + the path would be fine > > (that means that somebody unfamiliar with NUT's upstream can > > actually > > find the scripts to update this file). > > > Prior to pushing the changes in NUT and to generate the patches for > UPower, does the below header suit you: > > # Uninterruptible Power Supplies with USB HID interfaces > # > # http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rulesThat bit isn't necessary.> # > # This file was automatically generated by NUT: > # https://github.com/networkupstools/nut/ > # > # To keep up to date, monitor upstream NUT > # https://github.com/networkupstools/nut/commits/master/scripts/upower/95- > upower-hid.rules > # or checkout the NUT repository and call 'tools/nut-usbinfo.pl' > > Or do you see any other better wording?The rest is fine. Cheers
2015-06-08 13:06 GMT+02:00 Bastien Nocera <hadess at hadess.net>:> On Mon, 2015-06-08 at 09:45 +0200, Arnaud Quette wrote: > > > > > > 2015-06-04 13:04 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > > On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote: > > > > > > > > > > > > 2015-05-29 14:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > > > > On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote: > > > > > > Hi Richard and the list, > > > > > > > > > > > > you'll find attached a patch for 95-upower-hid.rules, which > > > adds: > > > > > > - the "usbmisc" filtering, as added in your repo, > > > > > > - more comments, including one that points at your UPower > > > repo, > > > > > > - 3 new manufacturers (Minibox, iDowell and Powerware) > > > > > > - a bunch of new devices (7 HP, 1 APC, 1 TrippLite, 2 > > > PowerCOM > > > > > and 2 > > > > > > Liebert) > > > > > > > > > > Could you please split those changes into 3 separate patches? > > > > > > > > since you already have the "usbmisc", I can possibly check to > > > split > > > > in 2 commits (1 for the comments, and 1 for the content update). > > > > would that suits you that way? > > > > > > Sure. > > > > > > > > It would also be useful to include a full URL to the NUT Perl > > > > > script > > > > > (to a git repository perhaps), so people don't need to check > > > out > > > > > the > > > > > full repo to update it. > > > > > > > > > as per Charles comments, beside from the perl script, you need > > > all > > > > the drivers/*hid.c files to extract the USB info. > > > > the added comment was just to shed light on the fact that it's an > > > > automated data extraction. > > > > I can reword to make it more clear if you want. > > > > > > Just changing the path to project page URL + the path would be fine > > > (that means that somebody unfamiliar with NUT's upstream can > > > actually > > > find the scripts to update this file). > > > > > Prior to pushing the changes in NUT and to generate the patches for > > UPower, does the below header suit you: > > > > # Uninterruptible Power Supplies with USB HID interfaces > > # > > # http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules > > That bit isn't necessary. >if you don't mind, I would prefer to keep it somewhere, just to remember (from a NUT point of view) where the upower repos. (and that file) is. so, not necessary, but useful for the NUT side...> > # > > # This file was automatically generated by NUT: > > # https://github.com/networkupstools/nut/ > > # > > # To keep up to date, monitor upstream NUT > > # > https://github.com/networkupstools/nut/commits/master/scripts/upower/95- > > upower-hid.rules > > # or checkout the NUT repository and call 'tools/nut-usbinfo.pl' > > > > Or do you see any other better wording? > > The rest is fine. >ok, thanks. I'll just wait for your ack on the above UPower repos. point, to push the remaining commit. thx and cheers, Arno -- Eaton Data Center Automation - Opensource Leader NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.fr -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/c8b9d025/attachment.html>