bugzilla-daemon at bugzilla.mindrot.org
2017-Jun-29 19:43 UTC
[Bug 2734] New: close() is called twice in confree()
https://bugzilla.mindrot.org/show_bug.cgi?id=2734
Bug ID: 2734
Summary: close() is called twice in confree()
Product: Portable OpenSSH
Version: 7.5p1
Hardware: Other
OS: Other
Status: NEW
Severity: minor
Priority: P5
Component: ssh-keyscan
Assignee: unassigned-bugs at mindrot.org
Reporter: bagajjal at microsoft.com
close() is called twice in confree()
Current code -
ssh_packet_close() internally calls the close() again.
confree(int s)
{
......
......
close(s);
......
......
if (fdcon[s].c_ssh) {
ssh_packet_close(fdcon[s].c_ssh);
......
......
}
Fix -
confree(int s)
{
......
......
if (fdcon[s].c_ssh) {
ssh_packet_close(fdcon[s].c_ssh);
free(fdcon[s].c_ssh);
fdcon[s].c_ssh = NULL;
} else
close(s);
......
......
}
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Jun-30 03:35 UTC
[Bug 2734] close() is called twice in confree()
https://bugzilla.mindrot.org/show_bug.cgi?id=2734
Darren Tucker <dtucker at zip.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtucker at zip.com.au
Blocks| |2698
Referenced Bugs:
https://bugzilla.mindrot.org/show_bug.cgi?id=2698
[Bug 2698] Tracking bug for OpenSSH 7.6 release
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Jun-30 03:37 UTC
[Bug 2734] close() is called twice in confree()
https://bugzilla.mindrot.org/show_bug.cgi?id=2734
Darren Tucker <dtucker at zip.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |djm at mindrot.org
Attachment #3001| |ok?(djm at mindrot.org)
Flags| |
--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 3001
--> https://bugzilla.mindrot.org/attachment.cgi?id=3001&action=edit
ssh-keyscan: Close ssh channel FDs only once
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Jun-30 04:00 UTC
[Bug 2734] close() is called twice in confree()
https://bugzilla.mindrot.org/show_bug.cgi?id=2734
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3001|ok?(djm at mindrot.org) |ok+
Flags| |
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Jun-30 04:18 UTC
[Bug 2734] close() is called twice in confree()
https://bugzilla.mindrot.org/show_bug.cgi?id=2734
Darren Tucker <dtucker at zip.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Patch applied and will be in 7.6. Thanks.
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-23 05:03 UTC
[Bug 2734] close() is called twice in confree()
https://bugzilla.mindrot.org/show_bug.cgi?id=2734
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #3 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.