search for: ssh_packet_close

...Hardware: Other OS: Other Status: NEW Severity: minor Priority: P5 Component: ssh-keyscan Assignee: unassigned-bugs at mindrot.org Reporter: bagajjal at microsoft.com close() is called twice in confree() Current code - ssh_packet_close() internally calls the close() again. confree(int s) { ...... ...... close(s); ...... ...... if (fdcon[s].c_ssh) { ssh_packet_close(fdcon[s].c_ssh); ...... ...... } Fix - confree(int s) { ...... .....

I hacked zstd support into OpenSSH a while ago and just started to clean it up in the recent days. The cleanup includes configuration support among other things that I did not have. During testing I noticed the following differences compared to zlib: - highly interactive shell output (as in refreshed at a _very_ high rate) may result in higher bandwidth compared to zlib. Since zstd is quicker

I added ZSTD support to OpenSSH roughly over a year and I've been playing with it ever since. The nice part is that ZSTD achieves reasonable compression (like zlib) but consumes little CPU so it is unlikely that compression becomes the bottle neck of a transfer. The compression overhead (CPU) is negligible even when uncompressed data is tunneled over the SSH connection (SOCKS proxy, port