openssh bugs - Sep 2016 - [Bug 2610] New: ssh should not complain about "no slots" when PKCS11Provider is specified, but no slot is found nor used

https://bugzilla.mindrot.org/show_bug.cgi?id=2610

            Bug ID: 2610
           Summary: ssh should not complain about "no slots" when
                    PKCS11Provider is specified, but no slot is found nor
                    used
           Product: Portable OpenSSH
           Version: 7.3p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Keywords: patch
          Severity: enhancement
          Priority: P5
         Component: Smartcard
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jjelen at redhat.com

Created attachment 2868
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2868&action=edit
drop verbosity of pkcs11 "errors"

Specifying a PKCS11Provider in the configuration and using the ssh
without a card inserted results in the error

    no slots

during the pkcs11 initialization. This error is in no way fatal and
usually does not require user attention. We might argue that that the
user should configure this option only when it is absolutely needed
using proper match blocks, but even though the verbosity is too high
and without any context does not make much sense.

Also other messages informing about "provider already registered" and
about "no keys" are not too important to show as error() form my point
of view. Also in most of these logging functions, there is missing
context and the user does not have the slightest idea where does these
messages come from and what do they mean. Prefixing them with the
function name also seems like reasonable idea.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2610

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |2594
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Thanks - I've committed a variant of this that moves the messages to
debug() and adds the provider ID and slot number to the other log calls
in there.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2594
[Bug 2594] Tracking bug for OpenSSH 7.4 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2610

PatRiehecky <jcpunk at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcpunk at gmail.com

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2610

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3058


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3058
[Bug 3058] ssh should not complain about "no slots" when
PKCS11Provider
is specified, but no slot is found nor used
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2610

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.