llvm dev - Aug 2020 - Phabricator new review email behaviour change?

Hi,

Is it me, or has Phabricator changed at some point in the past week or two
with regards to emails for newly created reviews? I noticed this morning
that my mailing rule (which previously simply marked new emails from
review at reviews.llvm.org with a specific tag) was no longer working for
them, and consequently, I missed several new review requests. (It wasn't an
issue for subsequent emails for the same review, for the record). I _think_
I've come up with a new rule for the current behaviour, but it was
concerning because I expect I'm not the only one who is in that boat.

Flagging it up in case it was an accident and/or so that people know of the
behaviour change.

Thanks,

James
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200827/743c352f/attachment.html>

Hi James,

Seems that `from:reviews at reviews.llvm.org` can still retrieve messages
related to Phabricator notifications (new differentials by yourself,
new differentials by others for which you subscribe, and commits
associated to differentials you subscribe). Do you have more
information about the anomaly you observed?

For example, from a message I received 4 days ago:

Content-Type: multipart/mixed;
boundary=3744cde2fafc2e1ab0b2e19da34774d501999ac79b12974f54ed8afbc945
Date: Sun, 23 Aug 2020 18:33:29 +0000 (UTC)
From: Fangrui Song via Phabricator <reviews at reviews.llvm.org>
Mime-Version: 1.0
Message-ID: <ycGDVmhWTWa_D3F1wF92qA at ismtpd0007p1iad2.sendgrid.net>
Thread-Topic: PHID-DREV-hd6ds2iug53idmfbdqxk

I think a rule matching from:reviews at reviews.llvm.org should work.

On Thu, Aug 27, 2020 at 1:12 AM James Henderson
<jh7370.2008 at my.bristol.ac.uk> wrote:
>
> Hi,
>
> Is it me, or has Phabricator changed at some point in the past week or two
with regards to emails for newly created reviews? I noticed this morning that my
mailing rule (which previously simply marked new emails from review at
reviews.llvm.org with a specific tag) was no longer working for them, and
consequently, I missed several new review requests. (It wasn't an issue for
subsequent emails for the same review, for the record). I _think_ I've come
up with a new rule for the current behaviour, but it was concerning because I
expect I'm not the only one who is in that boat.
>
> Flagging it up in case it was an accident and/or so that people know of the
behaviour change.
>
> Thanks,
>
> James


-- 
宋方睿

The issue seems to have been resolved, in that newer patches are indeed
coming from Phabricator again, but there was a period of a few days when it
stopped working. For example, I never received a reviews.llvm.org email for
the creation of the patch D86350, but did for follow-up comments. It did
appear in my llvm-commits folder, sent via the llvm-commits mailing list,
but since I didn't have the version from Phabricator, my
from:reviews at reviews.llvm.org filter didn't spot it, and it got filtered
away.

On Thu, 27 Aug 2020 at 18:33, Fāng-ruì Sòng <maskray at google.com> wrote:
> Hi James,
>
> Seems that `from:reviews at reviews.llvm.org` can still retrieve messages
> related to Phabricator notifications (new differentials by yourself,
> new differentials by others for which you subscribe, and commits
> associated to differentials you subscribe). Do you have more
> information about the anomaly you observed?
>
> For example, from a message I received 4 days ago:
>
> Content-Type: multipart/mixed;
> boundary=3744cde2fafc2e1ab0b2e19da34774d501999ac79b12974f54ed8afbc945
> Date: Sun, 23 Aug 2020 18:33:29 +0000 (UTC)
> From: Fangrui Song via Phabricator <reviews at reviews.llvm.org>
> Mime-Version: 1.0
> Message-ID: <ycGDVmhWTWa_D3F1wF92qA at ismtpd0007p1iad2.sendgrid.net>
> Thread-Topic: PHID-DREV-hd6ds2iug53idmfbdqxk
>
> I think a rule matching from:reviews at reviews.llvm.org should work.
>
> On Thu, Aug 27, 2020 at 1:12 AM James Henderson
> <jh7370.2008 at my.bristol.ac.uk> wrote:
> >
> > Hi,
> >
> > Is it me, or has Phabricator changed at some point in the past week or
> two with regards to emails for newly created reviews? I noticed this
> morning that my mailing rule (which previously simply marked new emails
> from review at reviews.llvm.org with a specific tag) was no longer working
> for them, and consequently, I missed several new review requests. (It
> wasn't an issue for subsequent emails for the same review, for the
record).
> I _think_ I've come up with a new rule for the current behaviour, but
it
> was concerning because I expect I'm not the only one who is in that
boat.
> >
> > Flagging it up in case it was an accident and/or so that people know
of
> the behaviour change.
> >
> > Thanks,
> >
> > James
>
>
>
> --
> 宋方睿
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200901/d655b2dd/attachment.html>