Has anyone noticed missing llvm-commits messages? Not all commits seem to generate emails to llvm-commits. For example, I can’t find an email for this commit: https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070 <https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html <http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191209/38992fd3/attachment.html>
Yep, there seems to be an issue with commits containing non-ASCII symbols (in Author: line?) On Tue, Dec 10, 2019 at 12:08 AM Don Hinton via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > Has anyone noticed missing llvm-commits messages? Not all commits seem to generate emails to llvm-commits. > > For example, I can’t find an email for this commit: https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070 > > Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.htmlRoman> _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> On Dec 9, 2019, at 1:10 PM, Roman Lebedev <lebedev.ri at gmail.com> wrote: > > Yep, there seems to be an issue with commits containing non-ASCII > symbols (in Author: line?)Ah, perhaps, but I don’t seen anything obvious, at least not in the log. And the author has other commits just before and after that did generate a messages, so it seems somewhat random to me.> > On Tue, Dec 10, 2019 at 12:08 AM Don Hinton via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> >> Has anyone noticed missing llvm-commits messages? Not all commits seem to generate emails to llvm-commits. >> >> For example, I can’t find an email for this commit: https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070 >> >> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html > > Roman > >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
On 12/09/2019 01:07 PM, Don Hinton via llvm-dev wrote:> Has anyone noticed missing llvm-commits messages? Not all commits seem to generate emails to llvm-commits. > > For example, I can’t find an email for this commit: https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070 >It looks like this commit was part of a push that contained 2 commits. Our mailer script was supposed to be able to handle this case, but it's possible there is a bug. When we were setting up the email, we did notice 1 missed email due to the webhook not being initiated from the GitHub side, but this is not the case here. -Tom> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html > > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >
On Tue, Dec 10, 2019 at 1:02 PM Tom Stellard via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > On 12/09/2019 01:07 PM, Don Hinton via llvm-dev wrote: > > Has anyone noticed missing llvm-commits messages? Not all commits seem to generate emails to llvm-commits. > > > > For example, I can’t find an email for this commit: https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070 > > > > It looks like this commit was part of a push that contained 2 commits. > Our mailer script was supposed to be able to handle this case, but > it's possible there is a bug. > > When we were setting up the email, we did notice 1 missed email > due to the webhook not being initiated from the GitHub side, but > this is not the case here.Here is another commit that looks like it never made it to the list: https://github.com/llvm/llvm-project/commit/5ee616a710bcb52cf9f1f7951644d098d38e7b6a#diff-b6b80c09b0caab74eede5945b15f16edR34 It also has unicode characters in the commit log. ~Aaron> > -Tom > > > > Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html > > > > > > > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reasonably Related Threads
- MIssing llvm-commits messages
- [cfe-dev] [Github] RFC: linear history vs merge commits
- [monorepo] Pre-push hook to prevent pushing merge commits
- [RFC] Documentation clarification: Phabricator, not the lists is the main entry point for new patches
- Please unbreak phabricator