Alfred Perlstein via llvm-dev
2016-Sep-13 06:43 UTC
[llvm-dev] https://reviews.llvm.org/D23393
On 9/12/16 11:40 PM, Davide Italiano wrote:> On Mon, Sep 12, 2016 at 10:03 PM, Alfred Perlstein via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> Hey folks, >> >> I'm new here, wasn't expecting to subscribe but here I am. The reason I'm >> here is that I came across a doc bug, I spent quite a bit of time learning >> all the tips and tricks for submitting patches to llvm including using >> phabricator and finally tweeting at the llvm account to get some attention. >> >> The patch is here: >> https://reviews.llvm.org/D23393 >> >> I looked in git and it doesn't look like this was pulled in. Has it been >> accepted? If no, did I miss some step? >> >> http://llvm.org/viewvc/llvm-project?rev=281297&view=rev >>Thanks Davide!! -Alfred
Piotr Padlewski via llvm-dev
2016-Sep-13 06:59 UTC
[llvm-dev] https://reviews.llvm.org/D23393
This is exactly why we should switch to github. It is much easier for new contributors to start with small fixes. 2016-09-12 23:43 GMT-07:00 Alfred Perlstein via llvm-dev < llvm-dev at lists.llvm.org>:> > > On 9/12/16 11:40 PM, Davide Italiano wrote: > >> On Mon, Sep 12, 2016 at 10:03 PM, Alfred Perlstein via llvm-dev >> <llvm-dev at lists.llvm.org> wrote: >> >>> Hey folks, >>> >>> I'm new here, wasn't expecting to subscribe but here I am. The reason >>> I'm >>> here is that I came across a doc bug, I spent quite a bit of time >>> learning >>> all the tips and tricks for submitting patches to llvm including using >>> phabricator and finally tweeting at the llvm account to get some >>> attention. >>> >>> The patch is here: >>> https://reviews.llvm.org/D23393 >>> >>> I looked in git and it doesn't look like this was pulled in. Has it been >>> accepted? If no, did I miss some step? >>> >>> http://llvm.org/viewvc/llvm-project?rev=281297&view=rev >>> >>> Thanks Davide!! > > > -Alfred > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160912/b69ed3a4/attachment.html>
Alfred Perlstein via llvm-dev
2016-Sep-13 07:05 UTC
[llvm-dev] https://reviews.llvm.org/D23393
+1, would be nice, that was a LOT of work, of which 80%+ felt unnecessary. I think LLVM is GREAT and really amazing, however quite frankly, although I enjoy contributing to open source, this experience made me more likely to search out projects which a lower bar to entry and I likely will not bother to contribute fixes unless they were critical due to this barrier. -Alfred On 9/12/16 11:59 PM, Piotr Padlewski wrote:> This is exactly why we should switch to github. It is much easier for > new contributors to start with small fixes. > > 2016-09-12 23:43 GMT-07:00 Alfred Perlstein via llvm-dev > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: > > > > On 9/12/16 11:40 PM, Davide Italiano wrote: > > On Mon, Sep 12, 2016 at 10:03 PM, Alfred Perlstein via llvm-dev > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > Hey folks, > > I'm new here, wasn't expecting to subscribe but here I > am. The reason I'm > here is that I came across a doc bug, I spent quite a bit > of time learning > all the tips and tricks for submitting patches to llvm > including using > phabricator and finally tweeting at the llvm account to > get some attention. > > The patch is here: > https://reviews.llvm.org/D23393 > <https://reviews.llvm.org/D23393> > > I looked in git and it doesn't look like this was pulled > in. Has it been > accepted? If no, did I miss some step? > > http://llvm.org/viewvc/llvm-project?rev=281297&view=rev > <http://llvm.org/viewvc/llvm-project?rev=281297&view=rev> > > Thanks Davide!! > > > -Alfred > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160913/139ac109/attachment.html>
Alex Bradbury via llvm-dev
2016-Sep-13 07:45 UTC
[llvm-dev] https://reviews.llvm.org/D23393
On 13 September 2016 at 07:59, Piotr Padlewski via llvm-dev <llvm-dev at lists.llvm.org> wrote:> This is exactly why we should switch to github. It is much easier for new > contributors to start with small fixes.There are two really quite separate issues here: 1) Patches, even trivial ones can sit unreviewed for long periods of time leading to a negative first time contribution experience. 2) Arguably, Phabricator provides a confusing interface for first-time or irregular users. There are efforts to improve this https://secure.phabricator.com/T5000 As for 1), this is something a few of us discussed at the LLVM Cauldron in Hebden Bridge last week which inspired me to give a lightning talk. Slides: <https://speakerdeck.com/asb/can-we-improve-the-experience-of-first-time-llvm-contributors> Video: <https://www.youtube.com/watch?v=32fmbEI9WrM> I'm intending to start an RFC thread when I get a chance. The tl;dr is I propose stealing Rust's highfive-bot and forming a team of eager volunteers who want to help improve response times for patches from first-time contributors. Best, Alex