llvm dev - Apr 2016 - [cfe-dev] [libunwind] __ELF__ macro for arm-none-eabi

On 18 April 2016 at 16:18, Silviu Baranga <Silviu.Baranga at arm.com>
wrote:
> This doesn't look like something ACLE specific (I can't find it in
the ACLE doc).
Sorry, I didn't mean it was ACLE, only that you guys were fiddling
with macros. :)

> This seems to be a generic macro. I think it would make sense to define it
> if we know we're emitting ELF.
Since the EABI only mentions ELF format, and we even have an ELF EABI,
wouldn't it make sense to assume the format is ELF when we select
EABI? I mean, we emit ELF on EABI anyway...

GCC does the same, if that's any argument. :)

cheers,
--renato

> -----Original Message-----
> From: Renato Golin [mailto:renato.golin at linaro.org]
> Sent: 18 April 2016 16:23
> To: Silviu Baranga
> Cc: Zhao, Weiming; cfe-dev at lists.llvm.org Developers; LLVM Dev; Bradley
> Smith
> Subject: Re: [cfe-dev] [libunwind] __ELF__ macro for arm-none-eabi
>
> On 18 April 2016 at 16:18, Silviu Baranga <Silviu.Baranga at arm.com>
wrote:
> > This doesn't look like something ACLE specific (I can't find
it in the ACLE
> doc).
>
> Sorry, I didn't mean it was ACLE, only that you guys were fiddling with
> macros. :)
Sure :)
>
>
> > This seems to be a generic macro. I think it would make sense to
> > define it if we know we're emitting ELF.
>
> Since the EABI only mentions ELF format, and we even have an ELF EABI,
> wouldn't it make sense to assume the format is ELF when we select EABI?
I
> mean, we emit ELF on EABI anyway...
>
> GCC does the same, if that's any argument. :)
Doing a grep "eabi" * -R | grep darwin in llvm I found the test
divmod-eabi.ll
which uses the triple armv7-apple-darwin-eabi. What format does that have?

We can find an thumbv7-apple-darwin-eabi target in compiler-rt as well (not in
the tests).

Cheers,
Silviu

IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.

On 18 April 2016 at 16:33, Silviu Baranga <Silviu.Baranga at arm.com>
wrote:
> Doing a grep "eabi" * -R | grep darwin in llvm I found the test
divmod-eabi.ll
> which uses the triple armv7-apple-darwin-eabi. What format does that have?
Certainly not ELF. :)

But I didn't mean "has eabi on triple", but "is in none-eabi
mode",
which may have to check a few more Triple properties.

For all the others (Linux, BSD), the __ELF__ is already being correctly emitted.

cheers,
--renato