Quentin Colombet via llvm-dev
2016-Mar-21 22:48 UTC
[llvm-dev] Need help with code generation
Hi Rafael,> On Mar 21, 2016, at 3:35 PM, Rafael Espíndola via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > On Mar 21, 2016 6:00 PM, "Lang Hames via llvm-dev" <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > > > Hi All, > > > > My understanding of the earlier thread is that it ended with "We agree to disagree for now, and (potentially) revisit this later". > > > > I'm not interested in starting any new discussions at the moment, but I want to make sure we avoid the echo chamber effect too, so: The position of the mach-o tool developers is that crashing on malformed input should be considered a bug, and to that end we're working to improve our error detection and reporting. > > Are you guys fixing llvm to also not crash on invalid input? >I believe the IR verifier already complains on such cases. Do you have cases where this leads to actual crashes? That would be a bug, IMHO.> What is the use case of having the property in one but not the other? > >It is good to do the right thing even though the other libraries might not (yet)? ;) Cheers, Q.> On a related note, it is the macho lld what currently prevents the asan bots from reporting failures. That would probably be a good place to start. > > Cheers, > Rafael > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160321/cee26bdc/attachment.html>
Rafael Espíndola via llvm-dev
2016-Mar-21 23:37 UTC
[llvm-dev] Need help with code generation
On Mar 21, 2016 6:48 PM, "Quentin Colombet" <qcolombet at apple.com> wrote:> > Hi Rafael, > >> On Mar 21, 2016, at 3:35 PM, Rafael Espíndola via llvm-dev <llvm-dev at lists.llvm.org> wrote:>> >> >> On Mar 21, 2016 6:00 PM, "Lang Hames via llvm-dev" <llvm-dev at lists.llvm.org> wrote:>> > >> > Hi All, >> > >> > My understanding of the earlier thread is that it ended with "We agreeto disagree for now, and (potentially) revisit this later".>> > >> > I'm not interested in starting any new discussions at the moment, butI want to make sure we avoid the echo chamber effect too, so: The position of the mach-o tool developers is that crashing on malformed input should be considered a bug, and to that end we're working to improve our error detection and reporting.>> >> Are you guys fixing llvm to also not crash on invalid input? > > > I believe the IR verifier already complains on such cases. >Not even close. Not the example in my other email. Cheers, Rafael -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160321/a1e90421/attachment.html>
Quentin Colombet via llvm-dev
2016-Mar-21 23:53 UTC
[llvm-dev] Need help with code generation
> On Mar 21, 2016, at 4:37 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote: > > > On Mar 21, 2016 6:48 PM, "Quentin Colombet" <qcolombet at apple.com <mailto:qcolombet at apple.com>> wrote: > > > > Hi Rafael, > > > >> On Mar 21, 2016, at 3:35 PM, Rafael Espíndola via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > >> > >> > >> On Mar 21, 2016 6:00 PM, "Lang Hames via llvm-dev" <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > >> > > >> > Hi All, > >> > > >> > My understanding of the earlier thread is that it ended with "We agree to disagree for now, and (potentially) revisit this later". > >> > > >> > I'm not interested in starting any new discussions at the moment, but I want to make sure we avoid the echo chamber effect too, so: The position of the mach-o tool developers is that crashing on malformed input should be considered a bug, and to that end we're working to improve our error detection and reporting. > >> > >> Are you guys fixing llvm to also not crash on invalid input? > > > > > > I believe the IR verifier already complains on such cases. > > > > Not even close. Not the example in my other email. > >Great example! I believe users generating this kind of IR would prefer an error on why the code is invalid to realize what they missed in their “frontend”. Could you file a PR? Thanks, -Quentin> Cheers, > Rafael >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160321/8d8e4a6c/attachment.html>